fix: disable dedupe when trigger/mutate (#271) #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a test demo |
tests: show proof of the fix
|
Thank you @rtxu and @mxschmitt ! |
shuding
approved these changes
Feb 24, 2020
|
This change is exactly what we were looking for thanks 👍 @shuding It looks like it should have made it into either the 0.5.0 or 0.5.1 tags but I can't see it in either. Has this been held back from release? https://github.com/vercel/swr/commits/0.5.1 |
|
@Tom-Goji I don’t think this was held back, are you seeing the same bug with the latest release? If so feel free to open a new issue with reproduction, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #271