Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keepPreviousData: return fallback instead of undefined value #4084

Merged
merged 2 commits into from
Feb 5, 2025
Merged

keepPreviousData: return fallback instead of undefined value #4084

merged 2 commits into from
Feb 5, 2025
+1 −1

Conversation

dvoytenko
Copy link
Member

@dvoytenko dvoytenko commented Feb 4, 2025 •
edited
Loading

We noticed that useSWR gets blocked in rare cases with keepPreviousData when the fallback is updated later.

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Feb 4, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@huozhi huozhi merged commit f6127e8 into main Feb 5, 2025
7 checks passed
@huozhi huozhi deleted the dimavoytenko/keep-previous-data-undefined branch February 5, 2025 01:00
@dvoytenko dvoytenko mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huozhi huozhi huozhi approved these changes

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvoytenko @huozhi