Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-commit, better linting and webstorm support #55

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Pre-commit, better linting and webstorm support #55

merged 2 commits into from
Oct 31, 2019

Conversation

sztadii
Copy link
Contributor

@sztadii sztadii commented Oct 31, 2019

Like we discussed at #48
I just added pre-commit ( which already catches some Eslint's warnings ).
Also, I added to ignore a folder .idea which is generated by Webstorm ( and other Jetbrains IDEs )

@sztadii sztadii requested review from shuding and Timer as code owners October 31, 2019 13:53
shuding
shuding approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much 🙏

@shuding shuding merged commit 090b8ae into vercel:master Oct 31, 2019
@shuding shuding mentioned this pull request Oct 31, 2019
Closed
@sztadii sztadii deleted the feature/development-improvements branch October 31, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuding shuding shuding approved these changes

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sztadii @shuding