Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add @types/lodash.throttle package #63

Merged
merged 5 commits into from
Nov 4, 2019
Merged

add @types/lodash.throttle package #63

merged 5 commits into from
Nov 4, 2019

Conversation

Go7hic
Copy link
Contributor

@Go7hic Go7hic commented Nov 3, 2019

add @types/lodash.throttle package

@Go7hic
add @types/lodash.throttle package
bcadb0b 
add @types/lodash.throttle package
@Go7hic Go7hic requested review from shuding and Timer as code owners November 3, 2019 04:10
shuding
shuding requested changes Nov 3, 2019
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! But I think it should be included in devDependencies, not dependencies.

Go7hic added 2 commits November 3, 2019 12:54
@Go7hic
add @types/lodash.throttle package
5a77909 
yarn add @types/lodash.throttle@4.1.1 --dev
@Go7hic
Update package.json
73e49e6
@shuding
Copy link
Member

shuding commented Nov 3, 2019

Thank you for your contribution! Could you please update yarn.lock as well? (same for #64)
Also the latest version should be "@types/lodash.throttle": "4.1.6",.

@shuding shuding added the on hold label Nov 3, 2019
@Go7hic
Copy link
Contributor Author

Go7hic commented Nov 4, 2019 •
edited
Loading

Thank you for your contribution! Could you please update yarn.lock as well? (same for #64)
Also the latest version should be "@types/lodash.throttle": "4.1.6",.

It‘s my wrong, i just change code online. I should clone to local install and run it

shuding
shuding approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shuding shuding merged commit a975652 into vercel:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuding shuding shuding approved these changes

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Go7hic @shuding