Add support for edge_config_item #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dglsparsons
force-pushed
the
07-29-implement_vercel_edge_config_item
branch
from
ef4cbde to
4dd189a
Compare
ecklf
reviewed
Oct 11, 2024
| }) | ||
| return c.doRequest(clientRequest{ | ||
| ctx: ctx, | ||
| method: "PATCH", |
There was a problem hiding this comment.
why is this patch instead of delete?
There was a problem hiding this comment.
The endpoint is to update the contents of an edge-config, rather than to manage a single edge config item. So you submit a list of 'operations', saying what you want to happen to each item.
ecklf
reviewed
Oct 11, 2024
| }) | ||
| err = c.doRequest(clientRequest{ | ||
| ctx: ctx, | ||
| method: "PATCH", |
There was a problem hiding this comment.
why is this patch instead of post?
ecklf
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #196 with additional tests + fixes.