Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mechanism to bypass turbo engine for annotated methods #7675

Closed
wants to merge 4 commits into from
Closed

feat: add mechanism to bypass turbo engine for annotated methods #7675

wants to merge 4 commits into from

Conversation

arlyon
Copy link
Contributor

@arlyon arlyon commented Mar 8, 2024 •
edited by padmaia
Loading

Description

Testing Instructions

Closes TURBO-2576

@vercel Vercel
Copy link

vercel bot commented Mar 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 11:10am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 11:10am
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 11:10am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 11:10am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 11:10am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 11:10am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 11:10am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 11:10am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 11:10am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 11:10am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 11:10am

@arlyon Graphite App
Copy link
Contributor Author

arlyon commented Mar 8, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @arlyon and the rest of your teammates on Graphite Graphite

This was referenced Mar 8, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024 •
edited
Loading

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust clippy
  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 46b7cf3 to aa14884 Compare March 8, 2024 09:01
@arlyon arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from 92ad696 to de937a1 Compare March 8, 2024 09:01
sokra
sokra reviewed Mar 8, 2024
View reviewed changes
crates/turbo-tasks-build/src/lib.rs
Comment on lines +239 to +240
if has_attribute(&fn_item.attrs, "function")
&& !ignored::task_ignored(&fn_item.sig.ident.to_string())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A problem is probably that just ignoring the attribute is not enough. The attribute is also changing the signature, e. g. async fn X() -> Result<Vc<Y>> becomes fn X() -> Vc<Y>.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I am going to see if it is possible to rewrite the signatures as well, have been messing around with it today to see if we can do that without requiring upstream tasks to change

@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from aa14884 to 9241414 Compare March 19, 2024 14:50
@arlyon arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from de937a1 to 4615e87 Compare March 19, 2024 14:50
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 9241414 to 9b6e234 Compare March 19, 2024 16:07
@arlyon arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from 4615e87 to abe08f2 Compare March 19, 2024 16:07
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 9b6e234 to 9139a05 Compare March 19, 2024 16:32
@arlyon arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from abe08f2 to 8224476 Compare March 19, 2024 16:32
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 9139a05 to c9e26bc Compare March 19, 2024 16:37
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 51a0259 to 01f812c Compare May 15, 2024 11:25
@arlyon arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from 9f50dd4 to d49e885 Compare May 15, 2024 11:25
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 01f812c to 08ad50d Compare May 15, 2024 15:25
@arlyon arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from d49e885 to fbab81c Compare May 15, 2024 15:25
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 08ad50d to ed4bedc Compare May 15, 2024 15:27
@arlyon arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from fbab81c to 739c4e3 Compare May 15, 2024 15:27
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from ed4bedc to 7a20d4d Compare May 16, 2024 08:06
@arlyon arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from 739c4e3 to 2671771 Compare May 16, 2024 08:06
@arlyon arlyon mentioned this pull request May 16, 2024
Merged
@arlyon
fix rustc bug in turbopack-trace-server
b17a90e
@arlyon
add additional filter modes for allocation and alloc count over time
4c292ac
@arlyon
add ability to filter by value and occurences
07e95b9
@arlyon
feat: add mechanism to bypass turbo engine for annotated methods
3fb2eb1 
This PR still needs some work, since we will need to transparently
forward VCs or eagerly evaluate them. We need to ensure that the parent
task is still lazy, but that we are just cutting out task tracking
between tasks.
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 7a20d4d to 07e95b9 Compare May 16, 2024 11:00
@arlyon arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from 2671771 to 3fb2eb1 Compare May 16, 2024 11:00
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 07e95b9 to 003b9b0 Compare May 22, 2024 07:37
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch 2 times, most recently from f0c3166 to 1b49d92 Compare May 31, 2024 17:50
@arlyon arlyon closed this Jun 4, 2024
@arlyon arlyon deleted the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch August 2, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arlyon @sokra