Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[turbo trace] add ability to filter by value and occurences #7674

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

arlyon
Copy link
Contributor

@arlyon arlyon commented Mar 8, 2024

Description

This adds extra filtering options to the trace server to limit by some concrete value and occurences. There is an accompanying PR for the trace-viewer to add filtering options to the web UI

Testing Instructions

Closes TURBO-2575

Copy link

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ❌ Failed (Inspect) Jun 1, 2024 6:00pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2024 6:00pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2024 6:00pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 1, 2024 6:00pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 1, 2024 6:00pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 1, 2024 6:00pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 1, 2024 6:00pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 1, 2024 6:00pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 1, 2024 6:00pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 1, 2024 6:00pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 1, 2024 6:00pm

Copy link
Contributor Author

arlyon commented Mar 8, 2024

Copy link
Contributor

github-actions bot commented Mar 8, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Mar 8, 2024

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Mar 8, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@arlyon arlyon force-pushed the 03-08-add_additional_filter_modes_for_allocation_and_alloc_count_over_time branch from f7624f1 to cc8a7d1 Compare March 8, 2024 09:01
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 46b7cf3 to aa14884 Compare March 8, 2024 09:01
@arlyon arlyon force-pushed the 03-08-add_additional_filter_modes_for_allocation_and_alloc_count_over_time branch from cc8a7d1 to 6c2de7a Compare March 19, 2024 14:50
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from aa14884 to 9241414 Compare March 19, 2024 14:50
@arlyon arlyon marked this pull request as ready for review March 19, 2024 14:51
@arlyon arlyon requested a review from a team as a code owner March 19, 2024 14:51
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 9241414 to 9b6e234 Compare March 19, 2024 16:07
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 9b6e234 to 9139a05 Compare March 19, 2024 16:32
@arlyon arlyon force-pushed the 03-08-add_additional_filter_modes_for_allocation_and_alloc_count_over_time branch from 6c2de7a to a959ee1 Compare March 19, 2024 16:37
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 9139a05 to c9e26bc Compare March 19, 2024 16:37
@arlyon arlyon force-pushed the 03-08-add_additional_filter_modes_for_allocation_and_alloc_count_over_time branch from 32d0747 to 4c292ac Compare May 16, 2024 11:00
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 7a20d4d to 07e95b9 Compare May 16, 2024 11:00
@arlyon arlyon force-pushed the 03-08-add_additional_filter_modes_for_allocation_and_alloc_count_over_time branch from 4c292ac to 19d73f2 Compare May 22, 2024 07:37
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 07e95b9 to 003b9b0 Compare May 22, 2024 07:37
Base automatically changed from 03-08-add_additional_filter_modes_for_allocation_and_alloc_count_over_time to main May 22, 2024 11:11
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 003b9b0 to f0c3166 Compare May 29, 2024 16:50
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from f0c3166 to 1b49d92 Compare May 31, 2024 17:50
@arlyon arlyon merged commit 517554e into main Jun 4, 2024
55 of 58 checks passed
@arlyon arlyon deleted the 03-08-add_ability_to_filter_by_value_and_occurences branch June 4, 2024 12:45
kdy1 added a commit to vercel/next.js that referenced this pull request Jun 5, 2024
# Turbopack

* vercel/turborepo#8272 <!-- Donny/강동윤 - feat:
Update `swc_core` to `v0.92.8` -->
* vercel/turborepo#8262 <!-- Alexander Lyon - add
crate to calculate prehashes -->
* vercel/turborepo#8174 <!-- Tobias Koppers - use
prehash to avoid rehashing the key in the task cache -->
* vercel/turborepo#7674 <!-- Alexander Lyon - [turbo
trace] add ability to filter by value and occurences -->
* vercel/turborepo#8287 <!-- Donny/강동윤 - feat:
Update `swc_core` to `v0.92.10` -->
* vercel/turborepo#8037 <!-- Alexander Lyon - create
turbo-static for compile time graph analysis -->
* vercel/turborepo#8293 <!-- Will Binns-Smith - Sync
Cargo.lock with Next.js -->
* vercel/turborepo#8239 <!-- Benjamin Woodruff -
Reduce amount of code generated by ValueDebugFormat -->
* vercel/turborepo#8304 <!-- Benjamin Woodruff -
Minor optimizations to the codegen of TaskFnInputFunction -->
* vercel/turborepo#8221 <!-- Donny/강동윤 - perf:
Introduce `RcStr` -->


### What?

I tried using `Arc<String>` in
vercel/turborepo#7772, but a team member suggested
creating a new type so we can replace underlying implementation easily
in the future.

### Why?

To reduce memory usage.

### How?

Closes PACK-2776
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
…urborepo#7674)

### Description

This adds extra filtering options to the trace server to limit by some concrete value and occurences. There is an accompanying PR for the trace-viewer to add filtering options to the web UI


Closes TURBO-2575
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…urborepo#7674)

### Description

This adds extra filtering options to the trace server to limit by some concrete value and occurences. There is an accompanying PR for the trace-viewer to add filtering options to the web UI


Closes TURBO-2575
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…urborepo#7674)

### Description

This adds extra filtering options to the trace server to limit by some concrete value and occurences. There is an accompanying PR for the trace-viewer to add filtering options to the web UI


Closes TURBO-2575
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
…urborepo#7674)

### Description

This adds extra filtering options to the trace server to limit by some concrete value and occurences. There is an accompanying PR for the trace-viewer to add filtering options to the web UI


Closes TURBO-2575
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 14, 2024
# Turbopack

* vercel/turborepo#8272 <!-- Donny/강동윤 - feat:
Update `swc_core` to `v0.92.8` -->
* vercel/turborepo#8262 <!-- Alexander Lyon - add
crate to calculate prehashes -->
* vercel/turborepo#8174 <!-- Tobias Koppers - use
prehash to avoid rehashing the key in the task cache -->
* vercel/turborepo#7674 <!-- Alexander Lyon - [turbo
trace] add ability to filter by value and occurences -->
* vercel/turborepo#8287 <!-- Donny/강동윤 - feat:
Update `swc_core` to `v0.92.10` -->
* vercel/turborepo#8037 <!-- Alexander Lyon - create
turbo-static for compile time graph analysis -->
* vercel/turborepo#8293 <!-- Will Binns-Smith - Sync
Cargo.lock with Next.js -->
* vercel/turborepo#8239 <!-- Benjamin Woodruff -
Reduce amount of code generated by ValueDebugFormat -->
* vercel/turborepo#8304 <!-- Benjamin Woodruff -
Minor optimizations to the codegen of TaskFnInputFunction -->
* vercel/turborepo#8221 <!-- Donny/강동윤 - perf:
Introduce `RcStr` -->


### What?

I tried using `Arc<String>` in
vercel/turborepo#7772, but a team member suggested
creating a new type so we can replace underlying implementation easily
in the future.

### Why?

To reduce memory usage.

### How?

Closes PACK-2776
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 15, 2024
* vercel/turborepo#8272 <!-- Donny/강동윤 - feat:
Update `swc_core` to `v0.92.8` -->
* vercel/turborepo#8262 <!-- Alexander Lyon - add
crate to calculate prehashes -->
* vercel/turborepo#8174 <!-- Tobias Koppers - use
prehash to avoid rehashing the key in the task cache -->
* vercel/turborepo#7674 <!-- Alexander Lyon - [turbo
trace] add ability to filter by value and occurences -->
* vercel/turborepo#8287 <!-- Donny/강동윤 - feat:
Update `swc_core` to `v0.92.10` -->
* vercel/turborepo#8037 <!-- Alexander Lyon - create
turbo-static for compile time graph analysis -->
* vercel/turborepo#8293 <!-- Will Binns-Smith - Sync
Cargo.lock with Next.js -->
* vercel/turborepo#8239 <!-- Benjamin Woodruff -
Reduce amount of code generated by ValueDebugFormat -->
* vercel/turborepo#8304 <!-- Benjamin Woodruff -
Minor optimizations to the codegen of TaskFnInputFunction -->
* vercel/turborepo#8221 <!-- Donny/강동윤 - perf:
Introduce `RcStr` -->

I tried using `Arc<String>` in
vercel/turborepo#7772, but a team member suggested
creating a new type so we can replace underlying implementation easily
in the future.

To reduce memory usage.

Closes PACK-2776
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
* vercel/turborepo#8272 <!-- Donny/강동윤 - feat:
Update `swc_core` to `v0.92.8` -->
* vercel/turborepo#8262 <!-- Alexander Lyon - add
crate to calculate prehashes -->
* vercel/turborepo#8174 <!-- Tobias Koppers - use
prehash to avoid rehashing the key in the task cache -->
* vercel/turborepo#7674 <!-- Alexander Lyon - [turbo
trace] add ability to filter by value and occurences -->
* vercel/turborepo#8287 <!-- Donny/강동윤 - feat:
Update `swc_core` to `v0.92.10` -->
* vercel/turborepo#8037 <!-- Alexander Lyon - create
turbo-static for compile time graph analysis -->
* vercel/turborepo#8293 <!-- Will Binns-Smith - Sync
Cargo.lock with Next.js -->
* vercel/turborepo#8239 <!-- Benjamin Woodruff -
Reduce amount of code generated by ValueDebugFormat -->
* vercel/turborepo#8304 <!-- Benjamin Woodruff -
Minor optimizations to the codegen of TaskFnInputFunction -->
* vercel/turborepo#8221 <!-- Donny/강동윤 - perf:
Introduce `RcStr` -->

I tried using `Arc<String>` in
vercel/turborepo#7772, but a team member suggested
creating a new type so we can replace underlying implementation easily
in the future.

To reduce memory usage.

Closes PACK-2776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants