Skip to content

Commit

Permalink
chore: move react, react-dom from devDependency to dependency in seve…
Browse files Browse the repository at this point in the history
…ral examples (#8192)

### Description
I moved the react and react-dom libraries from devDependencies to
dependencies in several examples.
Additionally, in the with-tailwind example, there was a duplicate react
dependency listed in both peerDependencies and devDependencies, so I
removed it from devDependencies.

That's a very minor question, but in the with-tailwind example, react is
specified as a peerDependency.
How should it be specified in the other examples?

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->

---------

Co-authored-by: Anthony Shew <anthony.shew@vercel.com>
  • Loading branch information
ghdtjgus76 and anthonyshew authored Jun 17, 2024
1 parent 761d1b3 commit 503276f
Show file tree
Hide file tree
Showing 18 changed files with 74 additions and 39 deletions.
4 changes: 3 additions & 1 deletion examples/basic/packages/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
"@types/react": "^18.2.61",
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"react": "^18.2.0",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0"
}
}
7 changes: 4 additions & 3 deletions examples/basic/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions examples/kitchen-sink/packages/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,11 @@
"@types/react": "^18.2.62",
"@types/react-dom": "^18.2.19",
"jest": "^29.7.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"tsup": "^8.0.2",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0",
"react-dom": "^18.2.0"
}
}
}
16 changes: 10 additions & 6 deletions examples/kitchen-sink/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion examples/with-berry/packages/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
"@types/react": "^18.2.61",
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"react": "^18.2.0",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0"
}
}
4 changes: 3 additions & 1 deletion examples/with-changesets/packages/acme-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,12 @@
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"@acme/eslint-config": "workspace:*",
"react": "^18.2.0",
"tsup": "^8.0.2",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0"
},
"publishConfig": {
"access": "public"
}
Expand Down
4 changes: 3 additions & 1 deletion examples/with-changesets/packages/acme-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,12 @@
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"@acme/eslint-config": "workspace:*",
"react": "^18.2.0",
"tsup": "^8.0.2",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0"
},
"publishConfig": {
"access": "public"
}
Expand Down
15 changes: 9 additions & 6 deletions examples/with-changesets/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion examples/with-docker/packages/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"@repo/eslint-config": "*",
"react": "^18.2.0",
"@repo/typescript-config": "*",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0"
}
}
4 changes: 3 additions & 1 deletion examples/with-gatsby/packages/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@
"@types/react": "^18.2.61",
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"react": "^18.2.0",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0"
}
}
8 changes: 5 additions & 3 deletions examples/with-gatsby/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion examples/with-npm/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion examples/with-npm/packages/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
"@types/react": "^18.2.61",
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"react": "^18.2.0",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0"
}
}
4 changes: 3 additions & 1 deletion examples/with-rollup/packages/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@
"@types/react": "^18.2.61",
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"react": "^18.2.0",
"rollup": "^4.12.0",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0"
}
}
8 changes: 5 additions & 3 deletions examples/with-rollup/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions examples/with-tailwind/packages/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@
"@types/react": "^18.2.61",
"autoprefixer": "^10.4.18",
"postcss": "^8.4.35",
"react": "^18.2.0",
"tailwindcss": "^3.4.1",
"typescript": "^5.3.3"
}
}
}
8 changes: 5 additions & 3 deletions examples/with-tailwind/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion examples/with-yarn/packages/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
"@types/react": "^18.2.61",
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"react": "^18.2.0",
"typescript": "^5.3.3"
},
"dependencies": {
"react": "^18.2.0"
}
}

0 comments on commit 503276f

Please sign in to comment.