Skip to content

Commit

Permalink
fix(affected): include dependents in affected filter (#9137)
Browse files Browse the repository at this point in the history
### Description

This PR changes `--affected` so packages that depend on affected
packages also get added.

### Testing Instructions

Added integration test to makes sure dependents of changed packages get
ran for `--affected`.
  • Loading branch information
chris-olszewski authored Sep 12, 2024
1 parent 33bef9e commit 76e8a6d
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
1 change: 1 addition & 0 deletions crates/turborepo-lib/src/run/scope/filter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ impl<'a, T: GitChangeDetector> FilterResolver<'a, T> {
include_uncommitted: true,
allow_unknown_objects: true,
}),
include_dependents: true,
..Default::default()
});
}
Expand Down
19 changes: 19 additions & 0 deletions turborepo-tests/integration/tests/affected-rdeps.t
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
Setup
$ . ${TESTDIR}/../../helpers/setup_integration_test.sh

Create a new branch
$ git checkout -b my-branch
Switched to a new branch 'my-branch'

Edit a file that affects `util` package
$ echo "foo" >> packages/util/index.js
Commit the change
$ git add .
$ git commit -m "add foo" --quiet

Validate that we run `util#build` and all rdeps
$ ${TURBO} run build --affected --dry=json | jq '.tasks | map(select(.command != "<NONEXISTENT>")) | map(.taskId)| sort'
[
"my-app#build",
"util#build"
]

0 comments on commit 76e8a6d

Please sign in to comment.