fix CSS HMR (#4815)

### Description * type=stylesheet => rel=stylesheet * remove timestamp, that's not needed * ensure correct encoding of the href
vercel · May 5, 2023 · d593105 · d593105
1 parent d01d70a
commit d593105
Show file tree

Hide file tree

Showing 36 changed files with 252 additions and 72 deletions.
diff --git a/crates/turbopack-dev/js/src/runtime.dom.js b/crates/turbopack-dev/js/src/runtime.dom.js
@@ -78,8 +78,13 @@ let BACKEND;
           return;
         }
 
+        const encodedChunkPath = chunkPath
+          .split("/")
+          .map((p) => encodeURIComponent(p))
+          .join("/");
+
         const previousLink = document.querySelector(
-          `link[type=stylesheet][href^="/${chunkPath}"]`
+          `link[rel=stylesheet][href^="/${encodedChunkPath}"]`
         );
 
         if (previousLink == null) {
@@ -89,7 +94,7 @@ let BACKEND;
 
         const link = document.createElement("link");
         link.rel = "stylesheet";
-        link.href = `/${chunkPath}?t=${Date.now()}`;
+        link.href = `/${encodedChunkPath}`;
         link.onerror = () => {
           reject();
         };

diff --git a/...hunk/output/crates_turbopack-tests_tests_snapshot_basic_async_chunk_input_index_0d348e.js b/...hunk/output/crates_turbopack-tests_tests_snapshot_basic_async_chunk_input_index_0d348e.js
diff --git a/.../chunked/output/crates_turbopack-tests_tests_snapshot_basic_chunked_input_index_e77e9f.js b/.../chunked/output/crates_turbopack-tests_tests_snapshot_basic_chunked_input_index_e77e9f.js
diff --git a/.../shebang/output/crates_turbopack-tests_tests_snapshot_basic_shebang_input_index_b1f0c2.js b/.../shebang/output/crates_turbopack-tests_tests_snapshot_basic_shebang_input_index_b1f0c2.js
diff --git a/...define/output/crates_turbopack-tests_tests_snapshot_comptime_define_input_index_6b0d2b.js b/...define/output/crates_turbopack-tests_tests_snapshot_comptime_define_input_index_6b0d2b.js
diff --git a/...utput/crates_turbopack-tests_tests_snapshot_css_absolute-uri-import_input_index_fa9a30.js b/...utput/crates_turbopack-tests_tests_snapshot_css_absolute-uri-import_input_index_fa9a30.js
diff --git a/...apshot/css/css/output/crates_turbopack-tests_tests_snapshot_css_css_input_index_37a138.js b/...apshot/css/css/output/crates_turbopack-tests_tests_snapshot_css_css_input_index_37a138.js
diff --git a/...motion/output/crates_turbopack-tests_tests_snapshot_emotion_emotion_input_index_b080c4.js b/...motion/output/crates_turbopack-tests_tests_snapshot_emotion_emotion_input_index_b080c4.js
diff --git a/...apshot/env/env/output/crates_turbopack-tests_tests_snapshot_env_env_input_index_29a23f.js b/...apshot/env/env/output/crates_turbopack-tests_tests_snapshot_env_env_input_index_29a23f.js
diff --git a/...me_entry/output/a587c_tests_snapshot_evaluated_entrry_runtime_entry_input_index_f59cc7.js b/...me_entry/output/a587c_tests_snapshot_evaluated_entrry_runtime_entry_input_index_f59cc7.js
diff --git a/...xample/output/crates_turbopack-tests_tests_snapshot_example_example_input_index_78b6bf.js b/...xample/output/crates_turbopack-tests_tests_snapshot_example_example_input_index_78b6bf.js
diff --git a/...js-2/output/crates_turbopack-tests_tests_snapshot_export-alls_cjs-2_input_index_289ae7.js b/...js-2/output/crates_turbopack-tests_tests_snapshot_export-alls_cjs-2_input_index_289ae7.js
diff --git a/...output/crates_turbopack-tests_tests_snapshot_export-alls_cjs-script_input_index_3e96b7.js b/...output/crates_turbopack-tests_tests_snapshot_export-alls_cjs-script_input_index_3e96b7.js
diff --git a/...ta/cjs/output/crates_turbopack-tests_tests_snapshot_import-meta_cjs_input_index_537553.js b/...ta/cjs/output/crates_turbopack-tests_tests_snapshot_import-meta_cjs_input_index_537553.js
diff --git a/...utput/79fb1_turbopack-tests_tests_snapshot_import-meta_esm-multiple_input_index_c00392.js b/...utput/79fb1_turbopack-tests_tests_snapshot_import-meta_esm-multiple_input_index_c00392.js
diff --git a/...utput/crates_turbopack-tests_tests_snapshot_import-meta_esm-mutable_input_index_6c9201.js b/...utput/crates_turbopack-tests_tests_snapshot_import-meta_esm-mutable_input_index_6c9201.js