Skip to content

Commit

Permalink
Remove pnpm plugin in Gatsby example. (#7916)
Browse files Browse the repository at this point in the history
### Description

Removes the `gatsby-plugin-pnpm` dependency because:
1) It doesn't look like it is needed. `turbo build` and `turbo dev`
still work.
2) It makes `npm` installation crash.

### Reviewer guide

Note that the only substantive changes are `web/package.json` and
`web/gatsby-config.ts`. The rest are from npm re-ordering the dependency
lists, package manager cleanup, and the lockfile updating.


Closes TURBO-2769
  • Loading branch information
anthonyshew committed Apr 9, 2024
1 parent b611074 commit d9e4583
Show file tree
Hide file tree
Showing 7 changed files with 2,669 additions and 2,494 deletions.
8 changes: 4 additions & 4 deletions examples/with-gatsby/apps/docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,18 @@
"lint": "eslint . --max-warnings 0"
},
"dependencies": {
"@repo/ui": "workspace:*",
"next": "^14.1.1",
"react": "18.2.0",
"react-dom": "18.2.0",
"@repo/ui": "workspace:*"
"react-dom": "18.2.0"
},
"devDependencies": {
"@next/eslint-plugin-next": "^14.1.1",
"@repo/eslint-config": "workspace:*",
"@repo/typescript-config": "workspace:*",
"@types/node": "^20.11.24",
"@types/react": "^18.2.61",
"@types/react-dom": "^18.2.19",
"@repo/eslint-config": "workspace:*",
"@repo/typescript-config": "workspace:*",
"eslint": "^8.57.0",
"typescript": "^5.3.3"
}
Expand Down
1 change: 0 additions & 1 deletion examples/with-gatsby/apps/web/gatsby-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const config: GatsbyConfig = {
},
graphqlTypegen: true,
plugins: [
`gatsby-plugin-pnpm`,
{
resolve: `gatsby-plugin-compile-es6-packages`,
options: {
Expand Down
1 change: 0 additions & 1 deletion examples/with-gatsby/apps/web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"gatsby-plugin-compile-es6-packages": "^2.1.1",
"gatsby-plugin-pnpm": "^1.2.10",
"typescript": "^5.3.3"
}
}
6 changes: 1 addition & 5 deletions examples/with-gatsby/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
"name": "with-gatsby",
"version": "0.0.0",
"private": true,
"workspaces": [
"apps/*",
"packages/*"
],
"scripts": {
"build": "turbo build",
"dev": "turbo dev",
Expand All @@ -20,5 +16,5 @@
"engines": {
"node": ">=18"
},
"packageManager": "pnpm@8.9.0"
"packageManager": "pnpm@8.11.0"
}
6 changes: 3 additions & 3 deletions examples/with-gatsby/packages/eslint-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@
"react-internal.js"
],
"devDependencies": {
"@typescript-eslint/eslint-plugin": "^7.1.0",
"@typescript-eslint/parser": "^7.1.0",
"@vercel/style-guide": "^5.2.0",
"eslint-config-turbo": "^1.12.4",
"eslint-config-prettier": "^9.1.0",
"eslint-config-turbo": "^1.12.4",
"eslint-plugin-only-warn": "^1.1.0",
"@typescript-eslint/parser": "^7.1.0",
"@typescript-eslint/eslint-plugin": "^7.1.0",
"typescript": "^5.3.3"
}
}
4 changes: 2 additions & 2 deletions examples/with-gatsby/packages/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
"lint": "eslint . --max-warnings 0"
},
"devDependencies": {
"@types/react": "^18.2.61",
"@types/react-dom": "^18.2.19",
"@repo/eslint-config": "workspace:*",
"@repo/typescript-config": "workspace:*",
"@types/react": "^18.2.61",
"@types/react-dom": "^18.2.19",
"eslint": "^8.57.0",
"react": "^18.2.0",
"typescript": "^5.3.3"
Expand Down
Loading

0 comments on commit d9e4583

Please sign in to comment.