pnpm7 filter by directory issue

[AntoineKM]

Same as #1920, but with pnpm 7

ok looks like with yarn3 it needs single quotation marks in when defining script --filter='./apps/*'

Originally posted by @gbkwiatt in #1920 (comment)

[chris-olszewski]

@AntoineKM Does the quoting the filter not work here? Are there docs that need updating?

If you could provide the error message you're getting that would be helpful

[AntoineKM]

Hi @chris-olszewski, thanks for the answer, I will give you more details but yes I think the doc needs a little update!

I just followed the following instructions on the kitchen repo (https://github.com/tonightpass/kitchen):
https://turbo.build/repo/docs/core-concepts/monorepos/filtering#filter-by-directory

First try without the quotes (fail):
Input:
turbo run build --filter=./examples/*

Output:

...\tonightpass\kitchen> pnpm build:examples

> @tonightpass/root@ build:examples ...\tonightpass\kitchen
> turbo run build --filter=./examples/*

No matches found: "--filter=./examples/*"
 ELIFECYCLE  Command failed with exit code 1.

Second try with quotes (work):
Input:
turbo run build --filter='./examples/*'

Output:

...\tonightpass\kitchen> pnpm build:examples

> @tonightpass/root@ build:examples ...\tonightpass\kitchen
> turbo run build --filter='./examples/*'

• Packages in scope: expo-typescript, next-typescript
• Running build in 2 packages
• Remote caching disabled

...classic logs...

 Tasks:    2 successful, 2 total
Cached:    0 cached, 2 total
  Time:    1m45.257s 

⠏ ...writing to cache...  [3s]

but before using pnpm on kitchen I was using yarn and I think this command was working without quotes (to be checked by your side, and thanks again for your attention on this issue)

[chris-olszewski]

Thanks for reporting this. Did a quick check and this is pnpm intercepting the --filter argument before it gets sent to us. I'll update the docs to quote the filter to avoid future confusion.