Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add headers to app routes IPC #3518

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Add headers to app routes IPC #3518

merged 1 commit into from
Jan 27, 2023

Conversation

alexkirsz
Copy link
Contributor

No description provided.

@alexkirsz alexkirsz requested a review from a team as a code owner January 27, 2023 18:54
@vercel
Copy link

vercel bot commented Jan 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 27, 2023 at 6:55PM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 27, 2023 at 6:55PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Jan 27, 2023 at 6:55PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 27, 2023 at 6:55PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 27, 2023 at 6:55PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Jan 27, 2023 at 6:55PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 27, 2023 at 6:55PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Jan 27, 2023 at 6:55PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 27, 2023 at 6:55PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Jan 27, 2023 at 6:55PM (UTC)

wbinnssmith
wbinnssmith approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@wbinnssmith wbinnssmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending CI 🙂

@jridgewell jridgewell added the pr: automerge Kodiak will merge these automatically after checks pass label Jan 27, 2023
@github-actions
Copy link
Contributor

Benchmark for f06db49

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack RCC/1000 modules N/A 9590.39µs ± 96.35µs N/A N/A
bench_hmr_to_commit/Turbopack RSC/1000 modules N/A 481.05ms ± 1.57ms N/A N/A
bench_hmr_to_eval/Turbopack RCC/1000 modules N/A 8534.62µs ± 82.30µs N/A N/A
bench_hydration/Turbopack RCC/1000 modules N/A 3725.86ms ± 9.75ms N/A N/A
bench_hydration/Turbopack RSC/1000 modules N/A 3272.66ms ± 8.81ms N/A N/A
bench_startup/Turbopack RCC/1000 modules 2838.51ms ± 9.21ms 2462.20ms ± 6.06ms -13.26% -12.26%
bench_startup/Turbopack RSC/1000 modules 2741.55ms ± 6.89ms 2379.70ms ± 8.42ms -13.20% -12.14%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9405.44µs ± 90.77µs 9329.44µs ± 91.85µs -0.81%
bench_hmr_to_commit/Turbopack RCC/1000 modules N/A 9590.39µs ± 96.35µs N/A N/A
bench_hmr_to_commit/Turbopack RSC/1000 modules N/A 481.05ms ± 1.57ms N/A N/A
bench_hmr_to_commit/Turbopack SSR/1000 modules 9533.86µs ± 85.87µs 9579.56µs ± 70.27µs +0.48%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8280.00µs ± 81.69µs 8327.77µs ± 70.90µs +0.58%
bench_hmr_to_eval/Turbopack RCC/1000 modules N/A 8534.62µs ± 82.30µs N/A N/A
bench_hmr_to_eval/Turbopack SSR/1000 modules 8465.14µs ± 103.50µs 8572.82µs ± 81.73µs +1.27%
bench_hydration/Turbopack RCC/1000 modules N/A 3725.86ms ± 9.75ms N/A N/A
bench_hydration/Turbopack RSC/1000 modules N/A 3272.66ms ± 8.81ms N/A N/A
bench_hydration/Turbopack SSR/1000 modules 3036.55ms ± 6.70ms 3013.98ms ± 7.03ms -0.74%
bench_startup/Turbopack CSR/1000 modules 2048.17ms ± 11.40ms 2049.01ms ± 7.68ms +0.04%
bench_startup/Turbopack RCC/1000 modules 2838.51ms ± 9.21ms 2462.20ms ± 6.06ms -13.26% -12.26%
bench_startup/Turbopack RSC/1000 modules 2741.55ms ± 6.89ms 2379.70ms ± 8.42ms -13.20% -12.14%
bench_startup/Turbopack SSR/1000 modules 2016.71ms ± 4.01ms 2006.77ms ± 4.41ms -0.49%

@github-actions
Copy link
Contributor

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Rust tests

See workflow summary for details

@jridgewell
Copy link
Contributor

Force merging. This PR is failing on #3521, and #3521 is failing on this PR.

@jridgewell jridgewell merged commit 9b5b507 into main Jan 27, 2023
@jridgewell jridgewell deleted the alexkirz/fix-tests branch January 27, 2023 20:56
@Brooooooklyn Brooooooklyn mentioned this pull request Jan 31, 2023
Merged
shuding pushed a commit to vercel/next.js that referenced this pull request Feb 1, 2023
@Brooooooklyn
build(cargo): update turbopack to turbopack-230201.1 (#45454)
221692b 
### Features
- vercel/turborepo#3514
- vercel/turborepo#3530
- vercel/turborepo#3510
- vercel/turborepo#3497

### Bug fixes
- vercel/turborepo#3545
- vercel/turborepo#3522
- vercel/turborepo#3525
- vercel/turborepo#3518
- vercel/turborepo#3501
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@alexkirsz
Add headers to app routes IPC (vercel/turborepo#3518)
22661ef
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@alexkirsz
Add headers to app routes IPC (vercel/turborepo#3518)
9a5695c
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@alexkirsz
Add headers to app routes IPC (vercel/turborepo#3518)
4a954a6
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@alexkirsz
Add headers to app routes IPC (vercel/turborepo#3518)
0224e8e
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@alexkirsz
Add headers to app routes IPC (vercel/turborepo#3518)
49cfe47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbinnssmith wbinnssmith wbinnssmith approved these changes

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexkirsz @jridgewell @wbinnssmith