Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty path specification #3538

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Handle empty path specification #3538

merged 2 commits into from
Jan 31, 2023

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Jan 31, 2023

  • Makes clear that an empty path specification ({}) is an error, with test (note + -> * change in regex)
  • Switch regex to named capture groups to reduce arbitrary-looking indices in the code

cc @chloetedder

@gsoltis gsoltis requested a review from a team as a code owner January 31, 2023 00:29
@vercel
Copy link

vercel bot commented Jan 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Jan 31, 2023 at 0:29AM (UTC)
9 Ignored Deployments
Name Status Preview Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 31, 2023 at 0:29AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Jan 31, 2023 at 0:29AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 31, 2023 at 0:29AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 31, 2023 at 0:29AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Jan 31, 2023 at 0:29AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 31, 2023 at 0:29AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Jan 31, 2023 at 0:29AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 31, 2023 at 0:29AM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Jan 31, 2023 at 0:29AM (UTC)

@github-actions
Copy link
Contributor

🟢 CI successful 🟢

Thanks

@gsoltis gsoltis added pr: automerge Kodiak will merge these automatically after checks pass labels Jan 31, 2023
@kodiakhq kodiakhq bot merged commit 871deb3 into main Jan 31, 2023
@kodiakhq kodiakhq bot deleted the gsoltis/selector_parser_error branch January 31, 2023 17:13
@gitworkflows gitworkflows mentioned this pull request Jan 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arlyon arlyon arlyon approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsoltis @arlyon