fix cache cleanup #3546

ForsakenHarmony · 2023-01-31T16:28:46Z

No description provided.

vercel · 2023-01-31T16:28:53Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Updated
examples-designsystem-docs	🔄 Building (Inspect)	Feb 1, 2023 at 4:32PM (UTC)
examples-tailwind-web	🔄 Building (Inspect)	Feb 1, 2023 at 4:32PM (UTC)
turbo-site	❌ Failed (Inspect)	Feb 1, 2023 at 4:32PM (UTC)

7 Ignored Deployments

Name	Status	Updated
examples-basic-web	⬜️ Ignored (Inspect)	Feb 1, 2023 at 4:32PM (UTC)
examples-cra-web	⬜️ Ignored (Inspect)	Feb 1, 2023 at 4:32PM (UTC)
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Feb 1, 2023 at 4:32PM (UTC)
examples-native-web	⬜️ Ignored (Inspect)	Feb 1, 2023 at 4:32PM (UTC)
examples-nonmonorepo	⬜️ Ignored (Inspect)	Feb 1, 2023 at 4:32PM (UTC)
examples-svelte-web	⬜️ Ignored (Inspect)	Feb 1, 2023 at 4:32PM (UTC)
examples-vite-web	⬜️ Ignored (Inspect)	Feb 1, 2023 at 4:32PM (UTC)

ForsakenHarmony · 2023-01-31T16:28:59Z

Current dependencies on/for this PR:

main
- PR fix cache cleanup #3546 👈

This comment was auto-generated by Graphite.

github-actions · 2023-01-31T16:53:38Z

Failing next.js integration test suites

Commit: 9ddcf88

Test summary

	main (`752319a` / v13.1.7-canary.1)	Current (`9ddcf88` / v13.1.7-canary.1)	Diff
Failed Suites	3	12	🔼 9
Failed Cases	9	42	🔼 33

✅ Fixed tests:
- test/development/acceptance/ReactRefresh.test.ts
- test/e2e/app-dir/app-rendering/rendering.test.ts
- test/integration/catches-missing-getStaticProps/test/index.test.js
❌ Newly failed tests:
- test/development/acceptance-app/component-stack.test.ts
- test/e2e/404-page-router/index.test.ts
- test/integration/broken-webpack-plugin/test/index.test.js
- test/development/acceptance/ReactRefreshLogBox-app-doc.test.ts
- test/e2e/app-dir/app-alias/app-alias.test.ts
- test/integration/404-page-custom-error/test/index.test.js
- test/development/acceptance-app/component-stack.test.ts
- test/e2e/404-page-router/index.test.ts
- test/integration/broken-webpack-plugin/test/index.test.js
- test/development/acceptance/ReactRefreshLogBox-app-doc.test.ts
- test/e2e/app-dir/app-alias/app-alias.test.ts
- test/integration/404-page-custom-error/test/index.test.js

Full test report

test/development/acceptance-app/component-stack.test.ts

Component Stack in error overlay > should show a component stack on hydration error

Expand output

● Component Stack in error overlay › should show a component stack on hydration error

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('[data-nextjs-toast]')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

test/e2e/404-page-router/index.test.ts

redirects and rewrites > navigation using button > should rewrite from middleware correctly
redirects and rewrites > navigation using button > should redirect from middleware correctly
redirects and rewrites > navigation using button > should rewrite from next.config.js correctly
redirects and rewrites > navigation using button > should redirect from next.config.js correctly
redirects and rewrites > navigation using button > should redirect using catchall from next.config.js correctly
redirects and rewrites > navigation using link > should rewrite from middleware correctly
redirects and rewrites > navigation using link > should redirect from middleware correctly
redirects and rewrites > navigation using link > should rewrite from next.config.js correctly
redirects and rewrites > navigation using link > should redirect from next.config.js correctly
redirects and rewrites > navigation using link > should redirect using catchall from next.config.js correctly

Expand output

● redirects and rewrites › navigation using link › should rewrite from middleware correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#link-middleware-rewrite')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

● redirects and rewrites › navigation using link › should redirect from middleware correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#link-middleware-redirect')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

● redirects and rewrites › navigation using link › should rewrite from next.config.js correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#link-config-rewrite')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

● redirects and rewrites › navigation using link › should redirect from next.config.js correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#link-config-redirect')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

● redirects and rewrites › navigation using link › should redirect using catchall from next.config.js correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#link-config-redirect-catchall')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

● redirects and rewrites › navigation using button › should rewrite from middleware correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#button-middleware-rewrite')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

● redirects and rewrites › navigation using button › should redirect from middleware correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#button-middleware-redirect')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

● redirects and rewrites › navigation using button › should rewrite from next.config.js correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#button-config-rewrite')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

● redirects and rewrites › navigation using button › should redirect from next.config.js correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#button-config-redirect')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

● redirects and rewrites › navigation using button › should redirect using catchall from next.config.js correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#button-config-redirect-catchall')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

test/integration/broken-webpack-plugin/test/index.test.js

Handles a broken webpack plugin (precompile) > should render error correctly

Expand output

● Handles a broken webpack plugin (precompile) › should render error correctly

expect(received).toContain(expected) // indexOf

Expected substring: "Internal Server Error"
Received string:    "failed to canonicalize embedded file path·
Caused by:
    No such file or directory (os error 2)"

  34 |   it('should render error correctly', async () => {
  35 |     const text = await renderViaHTTP(appPort, '/')
> 36 |     expect(text).toContain('Internal Server Error')
     |                  ^
  37 |
  38 |     expect(stderr).toMatch('Error: oops')
  39 |   })

  at Object.<anonymous> (integration/broken-webpack-plugin/test/index.test.js:36:18)

test/development/acceptance/ReactRefreshLogBox-app-doc.test.ts

ReactRefreshLogBox turbo > empty _app shows logbox
ReactRefreshLogBox turbo > empty _document shows logbox
ReactRefreshLogBox turbo > _app syntax error shows logbox
ReactRefreshLogBox turbo > _document syntax error shows logbox

Expand output

● ReactRefreshLogBox turbo › empty _app shows logbox

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  28 |         ])
  29 |       )
> 30 |       expect(await session.hasRedbox(true)).toBe(true)
     |                                             ^
  31 |       expect(await session.getRedboxDescription()).toMatchInlineSnapshot(
  32 |         `"Error: The default export is not a React Component in page: \\"/_app\\""`
  33 |       )

  at Object.<anonymous> (development/acceptance/ReactRefreshLogBox-app-doc.test.ts:30:45)

● ReactRefreshLogBox turbo › empty _document shows logbox

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  58 |         ])
  59 |       )
> 60 |       expect(await session.hasRedbox(true)).toBe(true)
     |                                             ^
  61 |       expect(await session.getRedboxDescription()).toMatchInlineSnapshot(
  62 |         `"Error: The default export is not a React Component in page: \\"/_document\\""`
  63 |       )

  at Object.<anonymous> (development/acceptance/ReactRefreshLogBox-app-doc.test.ts:60:45)

● ReactRefreshLogBox turbo › _app syntax error shows logbox

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  109 |         ])
  110 |       )
> 111 |       expect(await session.hasRedbox(true)).toBe(true)
      |                                             ^
  112 |       expect(await session.getRedboxSource()).toMatchSnapshot()
  113 |
  114 |       await session.patch(

  at Object.<anonymous> (development/acceptance/ReactRefreshLogBox-app-doc.test.ts:111:45)

● ReactRefreshLogBox turbo › _document syntax error shows logbox

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  158 |         ])
  159 |       )
> 160 |       expect(await session.hasRedbox(true)).toBe(true)
      |                                             ^
  161 |       expect(await session.getRedboxSource()).toMatchSnapshot()
  162 |
  163 |       await session.patch(

  at Object.<anonymous> (development/acceptance/ReactRefreshLogBox-app-doc.test.ts:160:45)

test/e2e/app-dir/app-alias/app-alias.test.ts

app-dir alias handling > should handle typescript paths alias correctly
app-dir alias handling > should resolve css imports from outside with src folder presented

Expand output

● app-dir alias handling › should handle typescript paths alias correctly

expect(received).toContain(expected) // indexOf

Expected substring: "click</button>"
Received string:    "failed to canonicalize embedded file path·
Caused by:
    No such file or directory (os error 2)"

  14 |     it('should handle typescript paths alias correctly', async () => {
  15 |       const html = await next.render('/button')
> 16 |       expect(html).toContain('click</button>')
     |                    ^
  17 |     })
  18 |
  19 |     it('should resolve css imports from outside with src folder presented', async () => {

  at Object.<anonymous> (e2e/app-dir/app-alias/app-alias.test.ts:16:20)

● app-dir alias handling › should resolve css imports from outside with src folder presented

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('button')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

test/integration/404-page-custom-error/test/index.test.js

Default 404 Page with custom _error > dev mode > should respond to 404 correctly
Default 404 Page with custom _error > dev mode > should render error correctly
Default 404 Page with custom _error > dev mode > should render index page normal

Expand output

● Default 404 Page with custom _error › dev mode › should respond to 404 correctly

expect(received).toBe(expected) // Object.is equality

Expected: 404
Received: 500

  24 |   it('should respond to 404 correctly', async () => {
  25 |     const res = await fetchViaHTTP(appPort, '/404')
> 26 |     expect(res.status).toBe(404)
     |                        ^
  27 |     expect(await res.text()).toContain('This page could not be found')
  28 |   })
  29 |

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:26:24)

● Default 404 Page with custom _error › dev mode › should render error correctly

expect(received).toContain(expected) // indexOf

Expected substring: "oops"
Received string:    "failed to canonicalize embedded file path·
Caused by:
    No such file or directory (os error 2)"

  30 |   it('should render error correctly', async () => {
  31 |     const text = await renderViaHTTP(appPort, '/err')
> 32 |     expect(text).toContain(isDev ? 'oops' : 'Internal Server Error')
     |                  ^
  33 |   })
  34 |
  35 |   it('should render index page normal', async () => {

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:32:18)

● Default 404 Page with custom _error › dev mode › should render index page normal

expect(received).toContain(expected) // indexOf

Expected substring: "hello from index"
Received string:    "failed to canonicalize embedded file path·
Caused by:
    No such file or directory (os error 2)"

  35 |   it('should render index page normal', async () => {
  36 |     const html = await renderViaHTTP(appPort, '/')
> 37 |     expect(html).toContain('hello from index')
     |                  ^
  38 |   })
  39 |
  40 |   if (!isDev) {

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:37:18)

test/development/acceptance-app/component-stack.test.ts

Component Stack in error overlay > should show a component stack on hydration error

Expand output

● Component Stack in error overlay › should show a component stack on hydration error

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('[data-nextjs-toast]')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

test/e2e/404-page-router/index.test.ts

redirects and rewrites > navigation using button > should rewrite from middleware correctly
redirects and rewrites > navigation using button > should redirect from middleware correctly
redirects and rewrites > navigation using button > should rewrite from next.config.js correctly
redirects and rewrites > navigation using button > should redirect from next.config.js correctly
redirects and rewrites > navigation using button > should redirect using catchall from next.config.js correctly
redirects and rewrites > navigation using link > should rewrite from middleware correctly
redirects and rewrites > navigation using link > should redirect from middleware correctly
redirects and rewrites > navigation using link > should rewrite from next.config.js correctly
redirects and rewrites > navigation using link > should redirect from next.config.js correctly
redirects and rewrites > navigation using link > should redirect using catchall from next.config.js correctly

Expand output

● redirects and rewrites › navigation using link › should rewrite from middleware correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#link-middleware-rewrite')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

● redirects and rewrites › navigation using link › should redirect from middleware correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#link-middleware-redirect')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

● redirects and rewrites › navigation using link › should rewrite from next.config.js correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#link-config-rewrite')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

● redirects and rewrites › navigation using link › should redirect from next.config.js correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#link-config-redirect')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

● redirects and rewrites › navigation using link › should redirect using catchall from next.config.js correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#link-config-redirect-catchall')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

● redirects and rewrites › navigation using button › should rewrite from middleware correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#button-middleware-rewrite')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

● redirects and rewrites › navigation using button › should redirect from middleware correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#button-middleware-redirect')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

● redirects and rewrites › navigation using button › should rewrite from next.config.js correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#button-config-rewrite')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

● redirects and rewrites › navigation using button › should redirect from next.config.js correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#button-config-redirect')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

● redirects and rewrites › navigation using button › should redirect using catchall from next.config.js correctly

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('#button-config-redirect-catchall')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

test/integration/broken-webpack-plugin/test/index.test.js

Handles a broken webpack plugin (precompile) > should render error correctly

Expand output

● Handles a broken webpack plugin (precompile) › should render error correctly

expect(received).toContain(expected) // indexOf

Expected substring: "Internal Server Error"
Received string:    "failed to canonicalize embedded file path·
Caused by:
    No such file or directory (os error 2)"

  34 |   it('should render error correctly', async () => {
  35 |     const text = await renderViaHTTP(appPort, '/')
> 36 |     expect(text).toContain('Internal Server Error')
     |                  ^
  37 |
  38 |     expect(stderr).toMatch('Error: oops')
  39 |   })

  at Object.<anonymous> (integration/broken-webpack-plugin/test/index.test.js:36:18)

test/development/acceptance/ReactRefreshLogBox-app-doc.test.ts

ReactRefreshLogBox turbo > empty _app shows logbox
ReactRefreshLogBox turbo > empty _document shows logbox
ReactRefreshLogBox turbo > _app syntax error shows logbox
ReactRefreshLogBox turbo > _document syntax error shows logbox

Expand output

● ReactRefreshLogBox turbo › empty _app shows logbox

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  28 |         ])
  29 |       )
> 30 |       expect(await session.hasRedbox(true)).toBe(true)
     |                                             ^
  31 |       expect(await session.getRedboxDescription()).toMatchInlineSnapshot(
  32 |         `"Error: The default export is not a React Component in page: \\"/_app\\""`
  33 |       )

  at Object.<anonymous> (development/acceptance/ReactRefreshLogBox-app-doc.test.ts:30:45)

● ReactRefreshLogBox turbo › empty _document shows logbox

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  58 |         ])
  59 |       )
> 60 |       expect(await session.hasRedbox(true)).toBe(true)
     |                                             ^
  61 |       expect(await session.getRedboxDescription()).toMatchInlineSnapshot(
  62 |         `"Error: The default export is not a React Component in page: \\"/_document\\""`
  63 |       )

  at Object.<anonymous> (development/acceptance/ReactRefreshLogBox-app-doc.test.ts:60:45)

● ReactRefreshLogBox turbo › _app syntax error shows logbox

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  109 |         ])
  110 |       )
> 111 |       expect(await session.hasRedbox(true)).toBe(true)
      |                                             ^
  112 |       expect(await session.getRedboxSource()).toMatchSnapshot()
  113 |
  114 |       await session.patch(

  at Object.<anonymous> (development/acceptance/ReactRefreshLogBox-app-doc.test.ts:111:45)

● ReactRefreshLogBox turbo › _document syntax error shows logbox

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  158 |         ])
  159 |       )
> 160 |       expect(await session.hasRedbox(true)).toBe(true)
      |                                             ^
  161 |       expect(await session.getRedboxSource()).toMatchSnapshot()
  162 |
  163 |       await session.patch(

  at Object.<anonymous> (development/acceptance/ReactRefreshLogBox-app-doc.test.ts:160:45)

test/e2e/app-dir/app-alias/app-alias.test.ts

app-dir alias handling > should handle typescript paths alias correctly
app-dir alias handling > should resolve css imports from outside with src folder presented

Expand output

● app-dir alias handling › should handle typescript paths alias correctly

expect(received).toContain(expected) // indexOf

Expected substring: "click</button>"
Received string:    "failed to canonicalize embedded file path·
Caused by:
    No such file or directory (os error 2)"

  14 |     it('should handle typescript paths alias correctly', async () => {
  15 |       const html = await next.render('/button')
> 16 |       expect(html).toContain('click</button>')
     |                    ^
  17 |     })
  18 |
  19 |     it('should resolve css imports from outside with src folder presented', async () => {

  at Object.<anonymous> (e2e/app-dir/app-alias/app-alias.test.ts:16:20)

● app-dir alias handling › should resolve css imports from outside with src folder presented

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('button')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

test/integration/404-page-custom-error/test/index.test.js

Default 404 Page with custom _error > dev mode > should respond to 404 correctly
Default 404 Page with custom _error > dev mode > should render error correctly
Default 404 Page with custom _error > dev mode > should render index page normal

Expand output

● Default 404 Page with custom _error › dev mode › should respond to 404 correctly

expect(received).toBe(expected) // Object.is equality

Expected: 404
Received: 500

  24 |   it('should respond to 404 correctly', async () => {
  25 |     const res = await fetchViaHTTP(appPort, '/404')
> 26 |     expect(res.status).toBe(404)
     |                        ^
  27 |     expect(await res.text()).toContain('This page could not be found')
  28 |   })
  29 |

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:26:24)

● Default 404 Page with custom _error › dev mode › should render error correctly

expect(received).toContain(expected) // indexOf

Expected substring: "oops"
Received string:    "failed to canonicalize embedded file path·
Caused by:
    No such file or directory (os error 2)"

  30 |   it('should render error correctly', async () => {
  31 |     const text = await renderViaHTTP(appPort, '/err')
> 32 |     expect(text).toContain(isDev ? 'oops' : 'Internal Server Error')
     |                  ^
  33 |   })
  34 |
  35 |   it('should render index page normal', async () => {

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:32:18)

● Default 404 Page with custom _error › dev mode › should render index page normal

expect(received).toContain(expected) // indexOf

Expected substring: "hello from index"
Received string:    "failed to canonicalize embedded file path·
Caused by:
    No such file or directory (os error 2)"

  35 |   it('should render index page normal', async () => {
  36 |     const html = await renderViaHTTP(appPort, '/')
> 37 |     expect(html).toContain('hello from index')
     |                  ^
  38 |   })
  39 |
  40 |   if (!isDev) {

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:37:18)

github-actions · 2023-01-31T17:36:37Z

Benchmark for 743cc05

Test	Base	PR	%	Significant %
bench_hydration/Turbopack RCC/1000 modules	3666.71ms ± 5.35ms	3718.27ms ± 12.52ms	+1.41%	+0.43%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	8759.98µs ± 80.12µs	8744.37µs ± 100.06µs	-0.18%
bench_hmr_to_commit/Turbopack RCC/1000 modules	9123.21µs ± 56.69µs	9132.02µs ± 53.09µs	+0.10%
bench_hmr_to_commit/Turbopack RSC/1000 modules	469.37ms ± 1.64ms	465.16ms ± 1.50ms	-0.90%
bench_hmr_to_commit/Turbopack SSR/1000 modules	9039.85µs ± 79.35µs	8976.69µs ± 82.52µs	-0.70%
bench_hmr_to_eval/Turbopack CSR/1000 modules	7886.85µs ± 50.27µs	7773.55µs ± 38.25µs	-1.44%
bench_hmr_to_eval/Turbopack RCC/1000 modules	8029.10µs ± 97.48µs	8045.80µs ± 73.08µs	+0.21%
bench_hmr_to_eval/Turbopack SSR/1000 modules	8062.75µs ± 71.56µs	8097.33µs ± 61.31µs	+0.43%
bench_hydration/Turbopack RCC/1000 modules	3666.71ms ± 5.35ms	3718.27ms ± 12.52ms	+1.41%	+0.43%
bench_hydration/Turbopack RSC/1000 modules	3290.61ms ± 11.75ms	3264.96ms ± 12.47ms	-0.78%
bench_hydration/Turbopack SSR/1000 modules	3070.40ms ± 6.44ms	3062.58ms ± 11.39ms	-0.25%
bench_startup/Turbopack CSR/1000 modules	2068.81ms ± 9.62ms	2069.21ms ± 19.76ms	+0.02%
bench_startup/Turbopack RCC/1000 modules	2508.66ms ± 5.27ms	2494.50ms ± 7.70ms	-0.56%
bench_startup/Turbopack RSC/1000 modules	2390.94ms ± 6.02ms	2406.80ms ± 8.58ms	+0.66%
bench_startup/Turbopack SSR/1000 modules	2036.77ms ± 5.88ms	2022.53ms ± 3.32ms	-0.70%

github-actions · 2023-01-31T18:28:00Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Rust tests
Rust benchmark tests
Formatting

See workflow summary for details

github-actions · 2023-02-01T17:38:12Z

Benchmark for `9ddcf88`

Test	Base	PR	%	Significant %
bench_startup/Turbopack SSR/1000 modules	2031.32ms ± 4.02ms	2052.82ms ± 6.15ms	+1.06%	+0.06%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	9607.52µs ± 53.46µs	9661.71µs ± 94.39µs	+0.56%
bench_hmr_to_commit/Turbopack RCC/1000 modules	10.00ms ± 0.09ms	10.03ms ± 0.07ms	+0.29%
bench_hmr_to_commit/Turbopack RSC/1000 modules	488.20ms ± 1.59ms	487.37ms ± 1.86ms	-0.17%
bench_hmr_to_commit/Turbopack SSR/1000 modules	9860.40µs ± 97.50µs	9922.59µs ± 109.78µs	+0.63%
bench_hmr_to_eval/Turbopack CSR/1000 modules	8699.03µs ± 65.72µs	8673.15µs ± 68.80µs	-0.30%
bench_hmr_to_eval/Turbopack RCC/1000 modules	8844.43µs ± 69.29µs	8821.42µs ± 79.62µs	-0.26%
bench_hmr_to_eval/Turbopack SSR/1000 modules	8801.07µs ± 102.30µs	8852.44µs ± 75.40µs	+0.58%
bench_hydration/Turbopack RCC/1000 modules	3826.86ms ± 22.15ms	3812.19ms ± 14.50ms	-0.38%
bench_hydration/Turbopack RSC/1000 modules	3311.73ms ± 12.01ms	3351.28ms ± 9.33ms	+1.19%
bench_hydration/Turbopack SSR/1000 modules	3128.48ms ± 16.57ms	3072.86ms ± 12.81ms	-1.78%
bench_startup/Turbopack CSR/1000 modules	2068.33ms ± 9.01ms	2055.63ms ± 14.28ms	-0.61%
bench_startup/Turbopack RCC/1000 modules	2493.89ms ± 5.63ms	2498.58ms ± 6.29ms	+0.19%
bench_startup/Turbopack RSC/1000 modules	2408.74ms ± 7.14ms	2402.03ms ± 8.28ms	-0.28%
bench_startup/Turbopack SSR/1000 modules	2031.32ms ± 4.02ms	2052.82ms ± 6.15ms	+1.06%	+0.06%

github-actions bot added the area: ci label Jan 31, 2023

vercel bot deployed to Preview – turbo-site January 31, 2023 16:29 View deployment

ForsakenHarmony marked this pull request as ready for review February 1, 2023 16:31

ForsakenHarmony requested review from a team as code owners February 1, 2023 16:31

ForsakenHarmony requested review from nathanhammond and NicholasLYang and removed request for nathanhammond and NicholasLYang February 1, 2023 16:31

kwonoj approved these changes Feb 1, 2023

View reviewed changes

fix cache cleanup

46e5fb8

ForsakenHarmony force-pushed the hrmny/fix-cache-cleanup branch from bf94ec2 to 46e5fb8 Compare February 1, 2023 16:32

vercel bot had a problem deploying to Preview – turbo-site February 1, 2023 16:33 Failure

ForsakenHarmony merged commit d60db67 into main Feb 1, 2023

ForsakenHarmony deleted the hrmny/fix-cache-cleanup branch February 1, 2023 18:56

gitworkflows mentioned this pull request Jan 18, 2024

[Snyk] Upgrade esbuild from 0.15.18 to 0.19.10 gsoc2/turbo#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix cache cleanup #3546

fix cache cleanup #3546

ForsakenHarmony commented Jan 31, 2023

vercel bot commented Jan 31, 2023 •

edited

Loading

ForsakenHarmony commented Jan 31, 2023

github-actions bot commented Jan 31, 2023 •

edited

Loading

github-actions bot commented Jan 31, 2023

github-actions bot commented Jan 31, 2023 •

edited

Loading

github-actions bot commented Feb 1, 2023

fix cache cleanup #3546

fix cache cleanup #3546

Conversation

ForsakenHarmony commented Jan 31, 2023

vercel bot commented Jan 31, 2023 • edited Loading

ForsakenHarmony commented Jan 31, 2023

github-actions bot commented Jan 31, 2023 • edited Loading

Failing next.js integration test suites

Test summary

github-actions bot commented Jan 31, 2023

Benchmark for 743cc05

github-actions bot commented Jan 31, 2023 • edited Loading

⚠️ CI failed ⚠️

github-actions bot commented Feb 1, 2023

Benchmark for 9ddcf88

vercel bot commented Jan 31, 2023 •

edited

Loading

github-actions bot commented Jan 31, 2023 •

edited

Loading

github-actions bot commented Jan 31, 2023 •

edited

Loading

Benchmark for `9ddcf88`