Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix json assets being inlined as objects instead of strings #3700

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

ForsakenHarmony
Copy link
Member

@ForsakenHarmony ForsakenHarmony commented Feb 8, 2023

#3676 seems to have accidentally removed it

@ForsakenHarmony
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ForsakenHarmony ForsakenHarmony enabled auto-merge (squash) February 8, 2023 20:54
@ForsakenHarmony ForsakenHarmony changed the title fix json assets fix json assets being inlined as objects instead of strings Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@vercel vercel deleted a comment from vercel bot Feb 8, 2023
@vercel
Copy link

vercel bot commented Feb 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-basic-web 🔄 Building (Inspect) Feb 8, 2023 at 9:21PM (UTC)
5 Ignored Deployments
Name Status Preview Comments Updated
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 8, 2023 at 9:21PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 8, 2023 at 9:21PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 8, 2023 at 9:21PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 8, 2023 at 9:21PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 8, 2023 at 9:21PM (UTC)

@ForsakenHarmony ForsakenHarmony merged commit a44847f into main Feb 8, 2023
@ForsakenHarmony ForsakenHarmony deleted the hrmny/fix-json-assets branch February 8, 2023 21:41
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Benchmark for 1920016

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 10.13ms ± 0.08ms 10.13ms ± 0.06ms -0.06%
bench_hmr_to_commit/Turbopack RCC/1000 modules 10.28ms ± 0.07ms 10.27ms ± 0.09ms -0.11%
bench_hmr_to_commit/Turbopack RSC/1000 modules 502.86ms ± 2.28ms 508.37ms ± 1.97ms +1.09%
bench_hmr_to_commit/Turbopack SSR/1000 modules 10.17ms ± 0.08ms 10.21ms ± 0.09ms +0.38%
bench_hmr_to_eval/Turbopack CSR/1000 modules 9074.69µs ± 70.56µs 9058.87µs ± 62.00µs -0.17%
bench_hmr_to_eval/Turbopack RCC/1000 modules 9141.83µs ± 81.89µs 9307.16µs ± 53.58µs +1.81%
bench_hmr_to_eval/Turbopack SSR/1000 modules 9175.67µs ± 75.37µs 9298.54µs ± 134.10µs +1.34%
bench_hydration/Turbopack RCC/1000 modules 4291.20ms ± 12.07ms 4284.93ms ± 6.50ms -0.15%
bench_hydration/Turbopack RSC/1000 modules 3896.70ms ± 23.42ms 3889.83ms ± 24.45ms -0.18%
bench_hydration/Turbopack SSR/1000 modules 3811.34ms ± 18.06ms 3801.17ms ± 9.70ms -0.27%
bench_startup/Turbopack CSR/1000 modules 2826.51ms ± 8.13ms 2804.98ms ± 11.02ms -0.76%
bench_startup/Turbopack RCC/1000 modules 2610.52ms ± 9.53ms 2590.21ms ± 6.99ms -0.78%
bench_startup/Turbopack RSC/1000 modules 2484.80ms ± 9.50ms 2483.65ms ± 8.38ms -0.05%
bench_startup/Turbopack SSR/1000 modules 2151.78ms ± 2.28ms 2153.83ms ± 1.33ms +0.09%

ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 25, 2024
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants