Add global hash inputs to dry run #3934

mehulkar · 2023-02-23T17:32:47Z

No description provided.

I use an unnamed struct everywhere because creating a named struct makes the hash object change and will bust everyones cache.

vercel · 2023-02-23T17:32:58Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
turbo-site	🔄 Building (Inspect)	Visit Preview		Feb 23, 2023 at 8:40PM (UTC)

9 Ignored Deployments

Name	Status	Updated
examples-basic-web	⬜️ Ignored (Inspect)	Feb 23, 2023 at 8:40PM (UTC)
examples-cra-web	⬜️ Ignored (Inspect)	Feb 23, 2023 at 8:40PM (UTC)
examples-designsystem-docs	⬜️ Ignored (Inspect)	Feb 23, 2023 at 8:40PM (UTC)
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Feb 23, 2023 at 8:40PM (UTC)
examples-native-web	⬜️ Ignored (Inspect)	Feb 23, 2023 at 8:40PM (UTC)
examples-nonmonorepo	⬜️ Ignored (Inspect)	Feb 23, 2023 at 8:40PM (UTC)
examples-svelte-web	⬜️ Ignored (Inspect)	Feb 23, 2023 at 8:40PM (UTC)
examples-tailwind-web	⬜️ Ignored (Inspect)	Feb 23, 2023 at 8:40PM (UTC)
examples-vite-web	⬜️ Ignored (Inspect)	Feb 23, 2023 at 8:40PM (UTC)

cli/internal/run/dry_run.go

github-actions · 2023-02-23T18:01:11Z

🟢 CI successful 🟢

Thanks

…-dry-run

mehulkar · 2023-02-23T19:50:22Z

cli/internal/run/dry_run.go

@@ -33,8 +34,32 @@ const missingTaskLabel = "<NONEXISTENT>"
 // DryRunSummary contains a summary of the packages and tasks that would run
 // if the --dry flag had not been passed
 type dryRunSummary struct {
-	Packages []string      `json:"packages"`
-	Tasks    []taskSummary `json:"tasks"`
+	GlobalHashSummary *globalHashSummary `json:"globalHashSummary"`


bikeshed this key name

mehulkar · 2023-02-23T19:50:56Z

cli/internal/run/dry_run.go

+	}
+	if err := w1.Flush(); err != nil {
+		return err
+	}


example of what this looks like:

I would dim these key / vals as well, but not a blocker.

I did that in a previous pass, but then felt it was more like the Packages In scope section rather than tasks section. I'll make a note of this and come back to it once all the pieces are in

mehulkar · 2023-02-23T20:41:15Z

cli/internal/run/dry_run.go

+	w1 := tabwriter.NewWriter(os.Stdout, 0, 0, 1, ' ', 0)
+	ui.Output("")
+	ui.Info(util.Sprintf("${CYAN}${BOLD}Global Hash Inputs${RESET}"))
+	fmt.Fprintln(w1, util.Sprintf("  ${GREY}Global Files\t=\t%d${RESET}", fileCount))


added a length here instead of the full list (json has the full list), since it could be really large. i'm not sure anyone will care about the full expanded list except to try to parse/operate on it

Always something we could revisit later if needed.

tknickman · 2023-02-23T20:55:54Z

cli/internal/run/dry_run.go

@@ -33,8 +34,32 @@ const missingTaskLabel = "<NONEXISTENT>"
 // DryRunSummary contains a summary of the packages and tasks that would run
 // if the --dry flag had not been passed
 type dryRunSummary struct {
-	Packages []string      `json:"packages"`
-	Tasks    []taskSummary `json:"tasks"`
+	GlobalHashSummary *globalHashSummary `json:"globalHashSummary"`


tknickman · 2023-02-23T20:57:31Z

cli/internal/run/dry_run.go

+	}
+	if err := w1.Flush(); err != nil {
+		return err
+	}


I would dim these key / vals as well, but not a blocker.

tknickman · 2023-02-23T20:58:07Z

cli/internal/run/dry_run.go

+	w1 := tabwriter.NewWriter(os.Stdout, 0, 0, 1, ' ', 0)
+	ui.Output("")
+	ui.Info(util.Sprintf("${CYAN}${BOLD}Global Hash Inputs${RESET}"))
+	fmt.Fprintln(w1, util.Sprintf("  ${GREY}Global Files\t=\t%d${RESET}", fileCount))


Always something we could revisit later if needed.

mehulkar added 3 commits February 23, 2023 09:24

Add a GlobalHashSummary to Dry Run Summary

83f5cca

I use an unnamed struct everywhere because creating a named struct makes the hash object change and will bust everyones cache.

Add test to ensure that dry run includes globalHash

f43ec47

Update hashes and unrelated tests becuase fixture turbo.json changes

25856b3

turbo-orchestrator bot added the team: turborepo label Feb 23, 2023

vercel bot deployed to Preview – turbo-site February 23, 2023 17:33 View deployment

Reduce scope of where globalHash local var is available

dc62892

mehulkar marked this pull request as ready for review February 23, 2023 17:36

mehulkar requested a review from a team as a code owner February 23, 2023 17:36

mehulkar requested review from tknickman and NicholasLYang February 23, 2023 17:36

tknickman reviewed Feb 23, 2023

View reviewed changes

cli/internal/run/dry_run.go Outdated Show resolved Hide resolved

mehulkar added 3 commits February 23, 2023 10:11

bool logic is hard

111a0e2

Remove env vars from printing in dry run for security

c996061

Merge branch 'main' into mehulkar/turbo-831-add-global-hash-inputs-to…

9224245

…-dry-run

vercel bot deployed to Preview – turbo-site February 23, 2023 18:21 View deployment

mehulkar added 3 commits February 23, 2023 11:49

Add test to ensure globalDeps are printing in dry run json

9914c68

Update hashes because fixture turbo.json changed

afad4db

Print GlobalHashInputs in --dry text summary also

29debb0

mehulkar requested a review from tknickman February 23, 2023 19:52

mehulkar commented Feb 23, 2023

View reviewed changes

Update test output for single package dry runs

0e6e047

mehulkar commented Feb 23, 2023

View reviewed changes

tknickman approved these changes Feb 23, 2023

View reviewed changes

mehulkar merged commit 86caa70 into main Feb 23, 2023

mehulkar deleted the mehulkar/turbo-831-add-global-hash-inputs-to-dry-run branch February 23, 2023 22:14

This was referenced Feb 23, 2023

Combine TaskSummary with RunSpec for 🪄 #3431

Closed

Include expanded inputs config for each task in dry run summary #3957

Merged

mehulkar mentioned this pull request Apr 27, 2023

Exclude Pipeline Definition from Global Hash #4545

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add global hash inputs to dry run #3934

Add global hash inputs to dry run #3934

mehulkar commented Feb 23, 2023

vercel bot commented Feb 23, 2023 •

edited

Loading

github-actions bot commented Feb 23, 2023 •

edited

Loading

mehulkar Feb 23, 2023

tknickman Feb 23, 2023

mehulkar Feb 23, 2023

tknickman Feb 23, 2023

mehulkar Feb 23, 2023

mehulkar Feb 23, 2023

tknickman Feb 23, 2023

tknickman Feb 23, 2023

tknickman Feb 23, 2023

tknickman Feb 23, 2023

Add global hash inputs to dry run #3934

Add global hash inputs to dry run #3934

Conversation

mehulkar commented Feb 23, 2023

vercel bot commented Feb 23, 2023 • edited Loading

github-actions bot commented Feb 23, 2023 • edited Loading

🟢 CI successful 🟢

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vercel bot commented Feb 23, 2023 •

edited

Loading

github-actions bot commented Feb 23, 2023 •

edited

Loading