Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port(turborepo): New Turbopath #4439

Merged
merged 19 commits into from
Apr 6, 2023

Conversation

NicholasLYang
Copy link
Contributor

@NicholasLYang NicholasLYang commented Apr 3, 2023

Description

This is meant as a very very simple port of turbopath to Rust. It's basically the Go code but the Rust version.

The goal here is to make something that works, and that we can extend with a little ChatGPT and copilot help.

Testing Instructions

There are doc tests on relevant functions and some regular tests too.

@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2023 5:24pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 6, 2023 5:24pm
examples-cra-web ⬜️ Ignored (Inspect) Apr 6, 2023 5:24pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 6, 2023 5:24pm
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 6, 2023 5:24pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 6, 2023 5:24pm
examples-native-web ⬜️ Ignored (Inspect) Apr 6, 2023 5:24pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Apr 6, 2023 5:24pm
examples-svelte-web ⬜️ Ignored (Inspect) Apr 6, 2023 5:24pm
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 6, 2023 5:24pm
examples-vite-web ⬜️ Ignored (Inspect) Apr 6, 2023 5:24pm

@vercel
Copy link

vercel bot commented Apr 3, 2023

@NicholasLYang is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@turbo-orchestrator turbo-orchestrator bot added area: ci area: docs Improvements or additions to documentation pkg: create-turbo Issues related to npx create-turbo pkg: turbo-codemod pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo pkg: turbo-ignore packages/turbo-ignore labels Apr 4, 2023
@NicholasLYang NicholasLYang marked this pull request as ready for review April 4, 2023 14:14
@NicholasLYang NicholasLYang requested review from a team as code owners April 4, 2023 14:14
@NicholasLYang NicholasLYang removed area: docs Improvements or additions to documentation pkg: create-turbo Issues related to npx create-turbo pkg: turbo-ignore packages/turbo-ignore pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo area: ci team: turbopack pkg: turbo-codemod labels Apr 4, 2023
@turbo-orchestrator turbo-orchestrator bot added area: ci area: docs Improvements or additions to documentation pkg: create-turbo Issues related to npx create-turbo pkg: turbo-codemod pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo pkg: turbo-ignore packages/turbo-ignore team: turbopack area: site labels Apr 4, 2023
@NicholasLYang NicholasLYang merged commit fc307b9 into vercel:main Apr 6, 2023
@ForsakenHarmony
Copy link
Member

I just saw this, and I'm very confused, this seems like it's completely unnecessary in rust, it's basically just std::path in worse?

ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

This is meant as a very very simple port of turbopath to Rust. It's
basically the Go code but the Rust version.

The goal here is to make something that works, and that we can extend
with a little ChatGPT and copilot help.

### Testing Instructions

There are doc tests on relevant functions and some regular tests too.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

This is meant as a very very simple port of turbopath to Rust. It's
basically the Go code but the Rust version.

The goal here is to make something that works, and that we can extend
with a little ChatGPT and copilot help.

### Testing Instructions

There are doc tests on relevant functions and some regular tests too.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

This is meant as a very very simple port of turbopath to Rust. It's
basically the Go code but the Rust version.

The goal here is to make something that works, and that we can extend
with a little ChatGPT and copilot help.

### Testing Instructions

There are doc tests on relevant functions and some regular tests too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ci pr: fixship A PR which is approved with notes and does not require re-review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants