Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bind to IPv6 and IPv4 #4565

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Bind to IPv6 and IPv4 #4565

merged 3 commits into from
Apr 13, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 13, 2023

Description

The std api doesn't allow to control the IPV6_ONLY flag for sockets and it defaults to true.
But we want to bind to both IPv6 and IPv4.

@sokra sokra requested a review from a team as a code owner April 13, 2023 08:32
@sokra sokra requested a review from alexkirsz April 13, 2023 08:32
@vercel
Copy link

vercel bot commented Apr 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Apr 13, 2023 1:41pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 1:41pm
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 13, 2023 1:41pm
examples-cra-web ⬜️ Ignored (Inspect) Apr 13, 2023 1:41pm
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 13, 2023 1:41pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 13, 2023 1:41pm
examples-native-web ⬜️ Ignored (Inspect) Apr 13, 2023 1:41pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Apr 13, 2023 1:41pm
examples-svelte-web ⬜️ Ignored (Inspect) Apr 13, 2023 1:41pm
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 13, 2023 1:41pm
examples-vite-web ⬜️ Ignored (Inspect) Apr 13, 2023 1:41pm

@github-actions
Copy link
Contributor

✅ This changes can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Apr 13, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Go e2e tests
  • Turbopack Rust benchmark tests (linux)
  • Turbopack Rust benchmark tests (mac/win, non-blocking)

See workflow summary for details

@alexkirsz
Copy link
Contributor

Missing Cargo.lock update?

@sokra sokra force-pushed the sokra/bind-to-ip-v4-and-v6 branch from 050a8ac to 91222a6 Compare April 13, 2023 08:58
@sokra sokra force-pushed the sokra/bind-to-ip-v4-and-v6 branch from 91222a6 to 64ed4f3 Compare April 13, 2023 11:50
@github-actions
Copy link
Contributor

Benchmark for a9d4e26

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules 8322.04µs ± 99.93µs 8688.80µs ± 52.09µs +4.41% +0.74%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9271.58µs ± 80.51µs 9286.40µs ± 26.45µs +0.16%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8322.04µs ± 99.93µs 8688.80µs ± 52.09µs +4.41% +0.74%
bench_startup/Turbopack CSR/1000 modules 896.06ms ± 2.24ms 899.15ms ± 4.80ms +0.34%

@github-actions
Copy link
Contributor

Benchmark for 329db5a

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8735.42µs ± 54.52µs 8792.73µs ± 69.01µs +0.66%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7854.62µs ± 52.42µs 7857.77µs ± 124.56µs +0.04%
bench_startup/Turbopack CSR/1000 modules 857.83ms ± 1.53ms 858.69ms ± 2.36ms +0.10%

@sokra sokra merged commit 4626147 into main Apr 13, 2023
@sokra sokra deleted the sokra/bind-to-ip-v4-and-v6 branch April 13, 2023 18:58
@sokra sokra mentioned this pull request Apr 14, 2023
Merged
sokra added a commit to vercel/next.js that referenced this pull request Apr 14, 2023
@sokra
provide the PORT env var based on server port, update turbopack (#48347)
51defb2 
### What?

gives user code access to `process.env.PORT` as current server port
avoid injecting env vars into code on server

### Why?

it might need construct an addr to fetch from api routes

fixes WEB-868

### Turbopack changes

* vercel/turborepo#4565 <!-- Tobias Koppers - Bind
to IPv6 and IPv4 -->
* vercel/turborepo#4570 <!-- Tobias Koppers - review
follow ups -->
* vercel/turborepo#4585 <!-- Tobias Koppers - fixup
bind v6 PR: add missing listen call -->
* ~vercel/turborepo#4546 <!-- Alex Kirszenberg -
Chunking Context Refactor pt. 3: Address PR comments from pt. 2 -->
* vercel/turborepo#4580 <!-- Tobias Koppers - remove
circular dependency -->
* vercel/turborepo#4582 <!-- Tobias Koppers - ignore
internal and server-relative url() in CSS -->
* vercel/turborepo#4579 <!-- Tobias Koppers - make
node bootstrap asset lazy -->
* vercel/turborepo#4581 <!-- Tobias Koppers - allow
to create stress test for client components -->
* vercel/turborepo#4584 <!-- Tobias Koppers -
improve node.js receive timeout -->
* vercel/turborepo#4583 <!-- Tobias Koppers - remove
panic since this might happen due to eventual consistency -->

fixes WEB-871
NicholasLYang pushed a commit to NicholasLYang/turbo that referenced this pull request Apr 21, 2023
@sokra @NicholasLYang
Bind to IPv6 and IPv4 (vercel#4565)
1f2b703 
### Description

The std api doesn't allow to control the `IPV6_ONLY` flag for sockets
and it defaults to true.
But we want to bind to both IPv6 and IPv4.
@jridgewell jridgewell mentioned this pull request Apr 26, 2023
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
Bind to IPv6 and IPv4 (vercel/turborepo#4565)
49768e1 
### Description

The std api doesn't allow to control the `IPV6_ONLY` flag for sockets
and it defaults to true.
But we want to bind to both IPv6 and IPv4.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
Bind to IPv6 and IPv4 (vercel/turborepo#4565)
85db3b2 
### Description

The std api doesn't allow to control the `IPV6_ONLY` flag for sockets
and it defaults to true.
But we want to bind to both IPv6 and IPv4.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
Bind to IPv6 and IPv4 (vercel/turborepo#4565)
e51de1c 
### Description

The std api doesn't allow to control the `IPV6_ONLY` flag for sockets
and it defaults to true.
But we want to bind to both IPv6 and IPv4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkirsz alexkirsz alexkirsz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @alexkirsz