-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cacheitem to restore HTTP cache. #4634
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,7 +81,7 @@ func makeValidTar(t *testing.T) *bytes.Buffer { | |
// my-pkg | ||
h := &tar.Header{ | ||
Name: "my-pkg/", | ||
Mode: int64(0644), | ||
Mode: int64(0755), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a valid configuration for a directory. |
||
Typeflag: tar.TypeDir, | ||
} | ||
if err := tw.WriteHeader(h); err != nil { | ||
|
@@ -182,7 +182,7 @@ func TestRestoreTar(t *testing.T) { | |
|
||
expectedFiles := []turbopath.AnchoredSystemPath{ | ||
turbopath.AnchoredUnixPath("extra-file").ToSystemPath(), | ||
turbopath.AnchoredUnixPath("my-pkg/").ToSystemPath(), | ||
turbopath.AnchoredUnixPath("my-pkg").ToSystemPath(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This output is only consumed inside of the |
||
turbopath.AnchoredUnixPath("my-pkg/some-file").ToSystemPath(), | ||
turbopath.AnchoredUnixPath("my-pkg/link-to-extra-file").ToSystemPath(), | ||
turbopath.AnchoredUnixPath("my-pkg/broken-link").ToSystemPath(), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should restore at the permissions set in the tar file which is why I had to repair the test.