Trigger turborepo tests in CI correctly #4717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mehulkar
commented
Apr 26, 2023
mehulkar
commented
- integration tests when integration tests change or any turborepo src changes
- e2e tests when e2e tests or any turborepo src changes
- change ids so they're more clear about which file changes matter when
- integration tests when integration tests change or any turborepo src changes - e2e tests when e2e tests or any turborepo src changes - change ids so they're more clear about which file changes matter when
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
mehulkar
commented
Apr 26, 2023
| cli/** | ||
| crates/turborepo* | ||
| crates/turborepo*/** | ||
| crates/turbo-updater |
There was a problem hiding this comment.
These crates patterns were incomplete, so I'm using the existing turborepo_rust definition above to determine when to run integration and e2e tests
mehulkar
commented
Apr 26, 2023
| go_e2e: ${{ steps.ci.outputs.diff != '' || steps.go.outputs.diff != '' || steps.go_e2e.outputs.diff != '' }} | ||
| go: ${{ steps.ci.outputs.diff != '' || steps.turborepo_go.outputs.diff != '' }} | ||
| go_e2e: ${{ steps.ci.outputs.diff != '' || steps.turborepo_go.outputs.diff != '' || steps.turborepo_rust.outputs.diff != '' || steps.turborepo_e2e.outputs.diff != '' }} | ||
| go_integration: ${{ steps.ci.outputs.diff != '' || steps.turborepo_go.outputs.diff != '' || steps.turborepo_rust.outputs.diff != '' || steps.turborepo_integration.outputs.diff != '' }} |
There was a problem hiding this comment.
e2e and integration tests now depend on all go and rust code, and also their respective test workspaces
sokra
approved these changes
Apr 26, 2023
|
✅ This change can build |
mehulkar
requested review from
gsoltis,
chris-olszewski and
NicholasLYang
and removed request for
nathanhammond and
arlyon
gsoltis
approved these changes
Apr 26, 2023
|
The Integration tests failed here because this branch is not rebased after #4712 was merged. Since the tests or the source themselves haven't changed here, I'm going to merge as-is |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.