Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove THASH #4724

Merged
merged 2 commits into from
May 18, 2023
Merged

Remove THASH #4724

merged 2 commits into from
May 18, 2023
+2 −48

Conversation

nathanhammond
Copy link
Contributor

After 1.9 as a deprecation period (and having heard no user feedback as to being an integral part of their workflow) this removes THASH.

Related: #4526

@nathanhammond nathanhammond requested a review from a team as a code owner April 27, 2023 07:25
@turbo-orchestrator turbo-orchestrator bot added area: docs Improvements or additions to documentation team: turborepo labels Apr 27, 2023
@vercel
Copy link

vercel bot commented Apr 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-cra-web 🔄 Building (Inspect) Apr 28, 2023 10:15am
examples-kitchensink-blog 🔄 Building (Inspect) Apr 28, 2023 10:15am
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 10:15am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 28, 2023 10:15am
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 28, 2023 10:15am
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 28, 2023 10:15am
examples-native-web ⬜️ Ignored (Inspect) Apr 28, 2023 10:15am
examples-nonmonorepo ⬜️ Ignored (Inspect) Apr 28, 2023 10:15am
examples-svelte-web ⬜️ Ignored (Inspect) Apr 28, 2023 10:15am
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 28, 2023 10:15am
examples-vite-web ⬜️ Ignored (Inspect) Apr 28, 2023 10:15am

@vercel
Copy link

vercel bot commented Apr 27, 2023

@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@nathanhammond nathanhammond requested a review from a team as a code owner April 27, 2023 08:09
mehulkar
mehulkar approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@mehulkar mehulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to wait for 1.10 to remove? cc @gsoltis

@nathanhammond
Copy link
Contributor Author

@mehulkar Absolutely. Removing features in patch releases is not good.

@nathanhammond nathanhammond added the pr: automerge Kodiak will merge these automatically after checks pass label May 18, 2023
@kodiakhq kodiakhq bot merged commit ebc002c into vercel:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehulkar mehulkar mehulkar approved these changes

@arlyon arlyon Awaiting requested review from arlyon

Assignees
No one assigned
Labels
area: docs Improvements or additions to documentation docs: next release pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanhammond @mehulkar