Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid errors in computing issue details #4817

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented May 4, 2023

Description

Better error message when import mapping fails

@sokra sokra requested a review from a team as a code owner May 4, 2023 08:45
@vercel
Copy link

vercel bot commented May 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview May 4, 2023 8:45am
10 Ignored Deployments
Name Status Preview Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 4, 2023 8:45am
examples-cra-web ⬜️ Ignored (Inspect) May 4, 2023 8:45am
examples-designsystem-docs ⬜️ Ignored (Inspect) May 4, 2023 8:45am
examples-gatsby-web ⬜️ Ignored (Inspect) May 4, 2023 8:45am
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 4, 2023 8:45am
examples-native-web ⬜️ Ignored (Inspect) May 4, 2023 8:45am
examples-nonmonorepo ⬜️ Ignored (Inspect) May 4, 2023 8:45am
examples-svelte-web ⬜️ Ignored (Inspect) May 4, 2023 8:45am
examples-tailwind-web ⬜️ Ignored (Inspect) May 4, 2023 8:45am
examples-vite-web ⬜️ Ignored (Inspect) May 4, 2023 8:45am

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

🟢 CI successful 🟢

Thanks

@sokra sokra merged commit a68486b into main May 4, 2023
@sokra sokra deleted the sokra/improve-error-reporting branch May 4, 2023 11:22
sokra added a commit to vercel/next.js that referenced this pull request May 4, 2023
### What?

Use pre-rewrite URL for rendering

### Why?

Rendering app pages needs the original user facing URL.

### Turbopack changes

* vercel/turborepo#4818 <!-- Tobias Koppers - pass
original url with content source data -->
* vercel/turborepo#4817 <!-- Tobias Koppers - avoid
errors in computing issue details -->
gsoltis pushed a commit that referenced this pull request May 5, 2023
### Description

Better error message when import mapping fails
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

Better error message when import mapping fails
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

Better error message when import mapping fails
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

Better error message when import mapping fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants