Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(turbo-gen): add @turbo/gen #4872

Merged
merged 1 commit into from
May 11, 2023
Merged

feat(turbo-gen): add @turbo/gen #4872

merged 1 commit into from
May 11, 2023

Conversation

tknickman
Copy link
Member

@tknickman tknickman commented May 8, 2023 •
edited
Loading

Description

@turbo/gen

Stacked on #4871 and should be reviewed / merged prior to this PR

@tknickman tknickman requested review from a team as code owners May 8, 2023 19:54
@tknickman tknickman requested review from mehulkar and NicholasLYang and removed request for a team May 8, 2023 19:54
@vercel
Copy link

vercel bot commented May 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo 🔄 Building (Inspect) Visit Preview May 11, 2023 8:43pm
examples-vite-web 🔄 Building (Inspect) Visit Preview May 11, 2023 8:43pm
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 11, 2023 8:43pm
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview May 11, 2023 8:43pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview May 11, 2023 8:43pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview May 11, 2023 8:43pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview May 11, 2023 8:43pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 11, 2023 8:43pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 11, 2023 8:43pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 11, 2023 8:43pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview May 11, 2023 8:43pm

@tknickman tknickman changed the title feat(turbo-gen): release @turbo/gen feat(turbo-gen): add @turbo/gen May 8, 2023
@tknickman tknickman force-pushed the tomknickman/turbo-1083-release-turbogen branch 2 times, most recently from 54f2487 to d6d5577 Compare May 8, 2023 20:00
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

Base automatically changed from tomknickman/turbo-1084-move-required-utilities-from-create to main May 8, 2023 20:53
@turbo-orchestrator turbo-orchestrator bot added the pkg: create-turbo Issues related to npx create-turbo label May 8, 2023
@tknickman tknickman force-pushed the tomknickman/turbo-1083-release-turbogen branch from d6d5577 to ad8258c Compare May 8, 2023 21:06
@turbo-orchestrator turbo-orchestrator bot removed the pkg: create-turbo Issues related to npx create-turbo label May 8, 2023
@tknickman tknickman force-pushed the tomknickman/turbo-1083-release-turbogen branch from 663ab71 to 3ed620d Compare May 10, 2023 14:26
mehulkar
mehulkar approved these changes May 10, 2023
View reviewed changes
packages/turbo-gen/README.md Outdated Show resolved Hide resolved
packages/turbo-gen/src/utils/getWorkspaceStructure.ts Show resolved Hide resolved
packages/turbo-gen/src/utils/plop.ts Show resolved Hide resolved
packages/turbo-gen/src/utils/workspaceRoots.ts Show resolved Hide resolved
@tknickman tknickman force-pushed the tomknickman/turbo-1083-release-turbogen branch from 3ed620d to 9eba872 Compare May 11, 2023 02:04
@tknickman tknickman force-pushed the tomknickman/turbo-1083-release-turbogen branch from 9eba872 to 72d3a49 Compare May 11, 2023 02:24
@tknickman tknickman mentioned this pull request May 11, 2023
Merged
NicholasLYang
NicholasLYang approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@NicholasLYang NicholasLYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder if at some point we'd consider porting this to Rust, but for now LGTM!

packages/turbo-gen/README.md Outdated Show resolved Hide resolved
packages/turbo-gen/src/utils/gatherAddRequirements.ts Outdated Show resolved Hide resolved
packages/turbo-gen/src/utils/getWorkspaceList.ts Show resolved Hide resolved
packages/turbo-gen/src/utils/getWorkspaceList.ts Show resolved Hide resolved
@tknickman
Copy link
Member Author

@NicholasLYang yea if we want to eventually do our own templating engine that is definitely the way to go - since we're building off of plop for this first crack at it we kind of need a node component so we can extend their API directly.

@tknickman tknickman force-pushed the tomknickman/turbo-1083-release-turbogen branch 2 times, most recently from 02ec5d1 to e5839e2 Compare May 11, 2023 20:23
@tknickman tknickman force-pushed the tomknickman/turbo-1083-release-turbogen branch from e5839e2 to a0344b3 Compare May 11, 2023 20:43
@tknickman tknickman enabled auto-merge (squash) May 11, 2023 21:13
@tknickman tknickman merged commit 5959a11 into main May 11, 2023
@tknickman tknickman deleted the tomknickman/turbo-1083-release-turbogen branch May 11, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehulkar mehulkar mehulkar approved these changes

@NicholasLYang NicholasLYang NicholasLYang approved these changes

Assignees
No one assigned
Labels
pkg: turbo-codemod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tknickman @mehulkar @NicholasLYang