Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve asset path #5072

Merged
merged 3 commits into from
May 23, 2023
Merged

improve asset path #5072

merged 3 commits into from
May 23, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented May 23, 2023

Description

  • include basename in static path
  • only use 8 chars for hash

This aligns with next.js, which seem to be a reasonable default.

Production mode can omit the basename and only include the hash.

@sokra sokra requested a review from a team as a code owner May 23, 2023 08:51
@vercel
Copy link

vercel bot commented May 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 23, 2023 3:36pm
examples-native-web 🔄 Building (Inspect) Visit Preview May 23, 2023 3:36pm
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 23, 2023 3:36pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 23, 2023 3:36pm
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview May 23, 2023 3:36pm
examples-designsystem-docs ⬜️ Ignored (Inspect) May 23, 2023 3:36pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview May 23, 2023 3:36pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview May 23, 2023 3:36pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 23, 2023 3:36pm
examples-vite-web ⬜️ Ignored (Inspect) May 23, 2023 3:36pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview May 23, 2023 3:36pm

@github-actions
Copy link
Contributor

✅ This change can build next-swc

crates/turbopack-dev/src/chunking_context.rs Outdated Show resolved Hide resolved
crates/turbopack-static/src/lib.rs Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

Linux Benchmark for 07b4a8a

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8598.48µs ± 53.38µs 8716.87µs ± 37.44µs +1.38%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7638.93µs ± 32.70µs 8280.32µs ± 635.64µs +8.40%
bench_startup/Turbopack CSR/1000 modules 921.09ms ± 3.83ms 909.00ms ± 6.33ms -1.31%

@github-actions
Copy link
Contributor

Linux Benchmark for a2f5cc8

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8510.34µs ± 39.15µs 8483.52µs ± 36.97µs -0.32%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7561.10µs ± 28.78µs 7635.08µs ± 140.38µs +0.98%
bench_startup/Turbopack CSR/1000 modules 872.10ms ± 1.68ms 875.42ms ± 2.50ms +0.38%

@sokra sokra merged commit 49ac908 into main May 23, 2023
@sokra sokra deleted the sokra/asset-path branch May 23, 2023 16:00
sokra added a commit to vercel/next.js that referenced this pull request May 23, 2023
### What?

align output path of turbopack and webpack

### Why?

passing test cases

### Turbopack Changes

* vercel/turborepo#5072 <!-- Tobias Koppers -
improve asset path -->
@github-actions
Copy link
Contributor

MacOS Benchmark for a2f5cc8

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 5243.35ms ± 1090.31ms 2745.87ms ± 57.69ms -47.63% -6.58%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 25.43ms ± 0.15ms 25.69ms ± 0.30ms +1.02%
bench_hmr_to_eval/Turbopack CSR/1000 modules 22.54ms ± 0.82ms 29.64ms ± 3.62ms +31.50%
bench_startup/Turbopack CSR/1000 modules 5243.35ms ± 1090.31ms 2745.87ms ± 57.69ms -47.63% -6.58%

hydRAnger pushed a commit to hydRAnger/next.js that referenced this pull request Jun 12, 2023
### What?

align output path of turbopack and webpack

### Why?

passing test cases

### Turbopack Changes

* vercel/turborepo#5072 <!-- Tobias Koppers -
improve asset path -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

* include basename in static path
* only use 8 chars for hash

This aligns with next.js, which seem to be a reasonable default.

Production mode can omit the basename and only include the hash.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

* include basename in static path
* only use 8 chars for hash

This aligns with next.js, which seem to be a reasonable default.

Production mode can omit the basename and only include the hash.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

* include basename in static path
* only use 8 chars for hash

This aligns with next.js, which seem to be a reasonable default.

Production mode can omit the basename and only include the hash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants