-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve asset path #5072
Merged
Merged
improve asset path #5072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only use 8 chars for hash
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
✅ This change can build |
alexkirsz
approved these changes
May 23, 2023
|
Linux Benchmark for 07b4a8aClick to view benchmark
|
Linux Benchmark for a2f5cc8Click to view benchmark
|
sokra
added a commit
to vercel/next.js
that referenced
this pull request
May 23, 2023
### What? align output path of turbopack and webpack ### Why? passing test cases ### Turbopack Changes * vercel/turborepo#5072 <!-- Tobias Koppers - improve asset path -->
MacOS Benchmark for a2f5cc8
Click to view full benchmark
|
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
### What? align output path of turbopack and webpack ### Why? passing test cases ### Turbopack Changes * vercel/turborepo#5072 <!-- Tobias Koppers - improve asset path -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description * include basename in static path * only use 8 chars for hash This aligns with next.js, which seem to be a reasonable default. Production mode can omit the basename and only include the hash.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description * include basename in static path * only use 8 chars for hash This aligns with next.js, which seem to be a reasonable default. Production mode can omit the basename and only include the hash.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description * include basename in static path * only use 8 chars for hash This aligns with next.js, which seem to be a reasonable default. Production mode can omit the basename and only include the hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This aligns with next.js, which seem to be a reasonable default.
Production mode can omit the basename and only include the hash.