Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add caching to chunk_content's graph walking #6242

Merged
merged 3 commits into from
Oct 21, 2023
Merged

Add caching to chunk_content's graph walking #6242

merged 3 commits into from
Oct 21, 2023

Conversation

jridgewell
Copy link
Contributor

@jridgewell jridgewell commented Oct 20, 2023 •
edited by padmaia
Loading

Description

Extracts chunk_content's processing of module references -> graph nodes into a turbo function, allowing us to cache the result of processing of every module.

Testing Instructions

Closes WEB-1817

@jridgewell jridgewell requested a review from sokra October 20, 2023 23:12
@jridgewell jridgewell requested a review from a team as a code owner October 20, 2023 23:12
@vercel
Copy link

vercel bot commented Oct 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 21, 2023 0:06am
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 21, 2023 0:06am
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 21, 2023 0:06am
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 21, 2023 0:06am
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2023 0:06am
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2023 0:06am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2023 0:06am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2023 0:06am
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2023 0:06am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2023 0:06am
turbo-site ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2023 0:06am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023 •
edited
Loading

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

Linux Benchmark for f65bfa2

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 31.58ms ± 2.30ms 31.80ms ± 2.11ms +0.68%
bench_hmr_to_eval/Turbopack CSR/1000 modules 31.16ms ± 2.04ms 31.42ms ± 2.49ms +0.82%
bench_startup/Turbopack CSR/1000 modules 1087.53ms ± 4.10ms 1119.81ms ± 12.50ms +2.97%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@sokra sokra merged commit f9236eb into main Oct 21, 2023
40 of 43 checks passed
@sokra sokra deleted the jrl-cache-chunk_content-walk branch October 21, 2023 04:05
@sokra sokra mentioned this pull request Oct 21, 2023
Merged
@jridgewell jridgewell mentioned this pull request Oct 21, 2023
Merged
sokra added a commit to vercel/next.js that referenced this pull request Oct 23, 2023
@sokra
update turbopack (#57176)
b64c042 
* vercel/turborepo#6241 <!-- Tobias Koppers - make
the daily ci faster -->
* vercel/turborepo#6242 <!-- Justin Ridgewell - Add
caching to `chunk_content`'s graph walking -->
* vercel/turborepo#6228 <!-- Tobias Koppers - Reduce
resolve and resolving tasks -->
* vercel/turborepo#6244 <!-- Tobias Koppers - avoid
cloning list -->
* vercel/turborepo#6246 <!-- Tobias Koppers - fix
symlink handling -->

Closes WEB-1819
sokra added a commit that referenced this pull request Oct 23, 2023
@jridgewell @sokra
Parallelize chunk_content walk (#6245)
aa3ef89 
### Description

#6242 extracted `chunk_content`'s
module references -> graph node walking into a cacheable helper, and now
we can parallelize that work to make it even faster.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes WEB-1822

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@jridgewell @sokra
Add caching to chunk_content's graph walking (vercel/turborepo#6242)
3cc0e8c 
### Description

Extracts `chunk_content`'s processing of module references -> graph
nodes into a turbo function, allowing us to cache the result of
processing of every module.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes WEB-1817

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@jridgewell @sokra
Parallelize chunk_content walk (vercel/turborepo#6245)
fccf3f8 
### Description

vercel/turborepo#6242 extracted `chunk_content`'s
module references -> graph node walking into a cacheable helper, and now
we can parallelize that work to make it even faster.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes WEB-1822

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@jridgewell @sokra
Add caching to chunk_content's graph walking (vercel/turborepo#6242)
326bb79 
### Description

Extracts `chunk_content`'s processing of module references -> graph
nodes into a turbo function, allowing us to cache the result of
processing of every module.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes WEB-1817

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@jridgewell @sokra
Parallelize chunk_content walk (vercel/turborepo#6245)
eefb419 
### Description

vercel/turborepo#6242 extracted `chunk_content`'s
module references -> graph node walking into a cacheable helper, and now
we can parallelize that work to make it even faster.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes WEB-1822

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@jridgewell @sokra
Add caching to chunk_content's graph walking (vercel/turborepo#6242)
3ecfd65 
### Description

Extracts `chunk_content`'s processing of module references -> graph
nodes into a turbo function, allowing us to cache the result of
processing of every module.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes WEB-1817

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@jridgewell @sokra
Parallelize chunk_content walk (vercel/turborepo#6245)
911d179 
### Description

vercel/turborepo#6242 extracted `chunk_content`'s
module references -> graph node walking into a cacheable helper, and now
we can parallelize that work to make it even faster.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes WEB-1822

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jridgewell @sokra