fix: catch import map lookup error properly in ResolvingIssue
#7167
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
sokra
reviewed
Jan 30, 2024
| @@ -2042,7 +2042,7 @@ pub async fn handle_resolve_error( | |||
| request_type: format!("{} request", reference_type.into_value()), | |||
| request, | |||
| resolve_options, | |||
| error_message: Some(err.to_string()), | |||
| error_message: Some(format!("{:?}", err)), | |||
There was a problem hiding this comment.
Suggested change
| error_message: Some(format!("{:?}", err)), | |
| error_message: Some(format!("{:?}", PrettyPrintError(&err))), |
That should make it even nicer
There was a problem hiding this comment.
true, I guess I can refactor the output of ResolvingIssues to use that
edit: nvm that works without the styled string stuff
sokra
approved these changes
Jan 30, 2024
ForsakenHarmony
force-pushed
the
hrmny/catch-import-map-error
branch
from
df7d107
to
2d9e649
Compare
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
Jan 31, 2024
# Turbopack * vercel/turborepo#7167 <!-- Leah - fix: catch import map lookup error properly in `ResolvingIssue` --> * vercel/turborepo#7182 <!-- Donny/강동윤 - feat: Re-enable `preset-env` mode of `styled-jsx` in turbopack --> * vercel/turborepo#7161 <!-- Tobias Koppers - add support for globs in sideEffects field in package.json --> * vercel/turborepo#7184 <!-- Donny/강동윤 - chore: Update `swc_core` to `v0.89.6` --> ### What? Update turbopack ### Why? To test vercel/turborepo#7182 against internal webapps. ### How? - Closes #57718 Closes PACK-2334
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…el/turborepo#7167) ### Description The wrong error / not all errors were caught before. This also adds the error trace to the error message. Closes PACK-2325
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…el/turborepo#7167) ### Description The wrong error / not all errors were caught before. This also adds the error trace to the error message. Closes PACK-2325
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…el/turborepo#7167) ### Description The wrong error / not all errors were caught before. This also adds the error trace to the error message. Closes PACK-2325
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…el/turborepo#7167) ### Description The wrong error / not all errors were caught before. This also adds the error trace to the error message. Closes PACK-2325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The wrong error / not all errors were caught before.
This also adds the error trace to the error message.
Closes PACK-2325