Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resolve): skip alias to d.ts #7684

Merged
merged 1 commit into from
Mar 9, 2024
Merged

feat(resolve): skip alias to d.ts #7684

merged 1 commit into from
Mar 9, 2024

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Mar 9, 2024

Description

Simple port to https://github.com/vercel/next.js/pull/11322/files#diff-f80cef26fea96d9530aab29fcaa89b2cc296a54a826a367254997d2885727d33R179.

Maybe we can consider to expose this as sort of configuration predicate for specific filter, but the depth of this call is somewhat deep from resolve context and so far there is only one cases (excluding d.ts), so followed same practices to exising next.js behavior.

Closes PACK-2701

Copy link

vercel bot commented Mar 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview Mar 9, 2024 0:44am
rust-docs 🔄 Building (Inspect) Visit Preview Mar 9, 2024 0:44am
turbo-site ✅ Ready (Inspect) Visit Preview Mar 9, 2024 0:44am
8 Ignored Deployments
Name Status Preview Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Mar 9, 2024 0:44am
examples-designsystem-docs ⬜️ Ignored (Inspect) Mar 9, 2024 0:44am
examples-gatsby-web ⬜️ Ignored (Inspect) Mar 9, 2024 0:44am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Mar 9, 2024 0:44am
examples-native-web ⬜️ Ignored (Inspect) Mar 9, 2024 0:44am
examples-svelte-web ⬜️ Ignored (Inspect) Mar 9, 2024 0:44am
examples-tailwind-web ⬜️ Ignored (Inspect) Mar 9, 2024 0:44am
examples-vite-web ⬜️ Ignored (Inspect) Mar 9, 2024 0:44am

Copy link
Contributor

github-actions bot commented Mar 9, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Mar 9, 2024

✅ This change can build next-swc

@kwonoj kwonoj enabled auto-merge (squash) March 9, 2024 00:50
Copy link
Contributor

github-actions bot commented Mar 9, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@kwonoj kwonoj merged commit 952d30a into main Mar 9, 2024
46 of 48 checks passed
@kwonoj kwonoj deleted the skip-alias-types branch March 9, 2024 00:50
kwonoj added a commit to vercel/next.js that referenced this pull request Mar 9, 2024
### What

* vercel/turborepo#7684 <!-- OJ Kwon -
feat(resolve): skip alias to d.ts -->



Closes PACK-2702
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

Simple port to
https://github.com/vercel/next.js/pull/11322/files#diff-f80cef26fea96d9530aab29fcaa89b2cc296a54a826a367254997d2885727d33R179.

Maybe we can consider to expose this as sort of configuration predicate
for specific filter, but the depth of this call is somewhat deep from
resolve context and so far there is only one cases (excluding d.ts), so
followed same practices to exising next.js behavior.

Closes PACK-2701
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

Simple port to
https://github.com/vercel/next.js/pull/11322/files#diff-f80cef26fea96d9530aab29fcaa89b2cc296a54a826a367254997d2885727d33R179.

Maybe we can consider to expose this as sort of configuration predicate
for specific filter, but the depth of this call is somewhat deep from
resolve context and so far there is only one cases (excluding d.ts), so
followed same practices to exising next.js behavior.

Closes PACK-2701
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

Simple port to
https://github.com/vercel/next.js/pull/11322/files#diff-f80cef26fea96d9530aab29fcaa89b2cc296a54a826a367254997d2885727d33R179.

Maybe we can consider to expose this as sort of configuration predicate
for specific filter, but the depth of this call is somewhat deep from
resolve context and so far there is only one cases (excluding d.ts), so
followed same practices to exising next.js behavior.

Closes PACK-2701
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

Simple port to
https://github.com/vercel/next.js/pull/11322/files#diff-f80cef26fea96d9530aab29fcaa89b2cc296a54a826a367254997d2885727d33R179.

Maybe we can consider to expose this as sort of configuration predicate
for specific filter, but the depth of this call is somewhat deep from
resolve context and so far there is only one cases (excluding d.ts), so
followed same practices to exising next.js behavior.

Closes PACK-2701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants