Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor GlobalCssAsset to fix dynamic import of css #7858

Merged
merged 2 commits into from
Apr 12, 2024
Merged

refactor GlobalCssAsset to fix dynamic import of css #7858

merged 2 commits into from
Apr 12, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 28, 2024 •
edited
Loading

Description

  • remove PassthroughModule
  • remove GlobalCssAsset
  • just return the inner asset directly without indirection

that fixes import("global.css")

Testing Instructions

fixes PACK-961

Closes PACK-2864

@sokra sokra requested a review from a team as a code owner March 28, 2024 14:10
@vercel Vercel
Copy link

vercel bot commented Mar 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 7:15am
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 7:15am
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 7:15am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 7:15am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 7:15am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 7:15am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 7:15am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 7:15am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 7:15am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 7:15am

@sokra sokra mentioned this pull request Mar 28, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited
Loading

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra marked this pull request as draft March 28, 2024 14:21
@sokra sokra force-pushed the sokra/refactor-global-css branch from 0b18b5c to 7c5e900 Compare April 8, 2024 07:41
@sokra sokra marked this pull request as ready for review April 8, 2024 08:26
@sokra sokra merged commit beba3b9 into main Apr 12, 2024
48 of 50 checks passed
@sokra sokra deleted the sokra/refactor-global-css branch April 12, 2024 06:07
@sokra sokra mentioned this pull request Apr 15, 2024
Merged
sokra added a commit to vercel/next.js that referenced this pull request Apr 15, 2024
@sokra
update turbopack (#64501)
3491417 
* vercel/turborepo#7858 <!-- Tobias Koppers -
refactor GlobalCssAsset to fix dynamic import of css -->
* vercel/turborepo#7944 <!-- Will Binns-Smith -
Update lockfile for compatibility with next.js -->
* vercel/turborepo#7936 <!-- Tobias Koppers - fix
panic when searching an the root span -->
* vercel/turborepo#7959 <!-- Tobias Koppers - fix
missing async loader -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
refactor GlobalCssAsset to fix dynamic import of css (vercel/turborep…
7336ae0 
…o#7858)

### Description

- remove PassthroughModule
- remove GlobalCssAsset
- just return the inner asset directly without indirection

that fixes `import("global.css")`

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->

fixes PACK-961

Closes PACK-2864
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
refactor GlobalCssAsset to fix dynamic import of css (vercel/turborep…
4834105 
…o#7858)

### Description

- remove PassthroughModule
- remove GlobalCssAsset
- just return the inner asset directly without indirection

that fixes `import("global.css")`

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->

fixes PACK-961

Closes PACK-2864
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
refactor GlobalCssAsset to fix dynamic import of css (vercel/turborep…
1491d89 
…o#7858)

### Description

- remove PassthroughModule
- remove GlobalCssAsset
- just return the inner asset directly without indirection

that fixes `import("global.css")`

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->

fixes PACK-961

Closes PACK-2864
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
refactor GlobalCssAsset to fix dynamic import of css (vercel/turborep…
d2421b5 
…o#7858)

### Description

- remove PassthroughModule
- remove GlobalCssAsset
- just return the inner asset directly without indirection

that fixes `import("global.css")`

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->

fixes PACK-961

Closes PACK-2864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

@arlyon arlyon Awaiting requested review from arlyon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @ForsakenHarmony