feat(Turborepo): wire file hashing to grpc server #7868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
gsoltis
force-pushed
the
03-25-feat_turborepo_file_hash_watching
branch
from
babe8ee
to
1ba0d7a
Compare
gsoltis
force-pushed
the
03-29-feat_turborepo_wire_file_hashing_to_grpc_server
branch
from
6d7d52a
to
ceea917
Compare
gsoltis
force-pushed
the
03-25-feat_turborepo_file_hash_watching
branch
from
1ba0d7a
to
de642b3
Compare
gsoltis
force-pushed
the
03-29-feat_turborepo_wire_file_hashing_to_grpc_server
branch
from
ceea917
to
2e706a9
Compare
gsoltis
force-pushed
the
03-25-feat_turborepo_file_hash_watching
branch
2 times, most recently
from
ac229a4
to
93d74a7
Compare
gsoltis
force-pushed
the
03-29-feat_turborepo_wire_file_hashing_to_grpc_server
branch
from
2e706a9
to
cc9adaa
Compare
gsoltis
force-pushed
the
03-25-feat_turborepo_file_hash_watching
branch
from
93d74a7
to
8478cd5
Compare
gsoltis
force-pushed
the
03-29-feat_turborepo_wire_file_hashing_to_grpc_server
branch
from
cc9adaa
to
4e290a9
Compare
gsoltis
force-pushed
the
03-25-feat_turborepo_file_hash_watching
branch
from
8478cd5
to
232ce61
Compare
gsoltis
force-pushed
the
03-29-feat_turborepo_wire_file_hashing_to_grpc_server
branch
from
4e290a9
to
ea03d90
Compare
NicholasLYang
approved these changes
Apr 18, 2024
| } | ||
| } | ||
| }); | ||
| let mut hash_object = match hash_object { |
There was a problem hiding this comment.
not very important but you could probably use or_else or unwrap_or_else here.
There was a problem hiding this comment.
I looked at doing that, but it gets awkward since we're starting with an Option, but the fallback calculation produces a Result where we want to short-circuit, but the overall closure returns an Option<Result<_, _>>. ? doesn't really work in that context, so you end up with the match either way.
| // active tokio context. Constructing it directly in | ||
| // the rayon thread doesn't provide one and will crash at runtime. | ||
| handle | ||
| .block_on(async { |
There was a problem hiding this comment.
I'm a little confused by the docs for this method. It says the method panics "if called within an asynchronous execution context". Does that mean if it's called in an async function?
There was a problem hiding this comment.
Essentially, yes, if it's running from a task managed by an async runtime, it will panic. In this case, we're running from the rayon threadpool.
gsoltis
deleted the
03-29-feat_turborepo_wire_file_hashing_to_grpc_server
branch
This was referenced May 18, 2024
This was referenced May 25, 2024
This was referenced Jun 2, 2024
This was referenced Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Instructions
Existing integration test suite
Closes TURBO-2736