Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(turbo-ignore): usage metrics #7897

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

tknickman
Copy link
Member

Description

Anonymous usage metrics for turbo-ignore. Will help inform future roadmap for the tool.

@tknickman tknickman requested a review from a team as a code owner April 3, 2024 15:15
Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 8:54pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 8:54pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 8:54pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 8:54pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 8:54pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 8:54pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 8:54pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 8:54pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 8:54pm
rust-docs ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 8:54pm

@tknickman tknickman force-pushed the tomknickman/turbo-2689-instrument-turbo-ignore branch from f6255e7 to 433665a Compare April 3, 2024 15:17
Copy link

socket-security bot commented Apr 3, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/ci-info@4.0.0 environment 0 27.3 kB sibiraj-s

View full report↗︎

@@ -24,7 +24,7 @@
},
"dependencies": {
"chalk": "4.1.2",
"commander": "^10.0.0",
"commander": "^11.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating to use same version across all our CLIs. Nothing breaking is relevant for us:

https://github.com/tj/commander.js/releases/tag/v11.1.0

Copy link
Contributor

@arlyon arlyon Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wish pnpm had workspace-wide package version definitions like in cargo...

Copy link
Contributor

github-actions bot commented Apr 3, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Apr 3, 2024

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Apr 3, 2024

🟢 CI successful 🟢

Thanks

Copy link
Contributor

@arlyon arlyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are adding to a new product here is proof it respects tracking env vars for posterity https://github.com/vercel/turbo/blob/583bb0934a2521b7549380f9c49b34565804b5b1/packages/turbo-telemetry/src/config.ts#L54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-turbo Issues related to npx create-turbo pkg: turbo-ignore packages/turbo-ignore pkg: turbo-telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants