Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(turbo-repository): fix napi build with LLD #7992

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

ForsakenHarmony
Copy link
Member

@ForsakenHarmony ForsakenHarmony commented Apr 16, 2024

Description

Ported from the next.js PR.

Library release: https://github.com/vercel/turbo/actions/runs/8711878544

Closes PACK-2970

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 9:08pm
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 9:08pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 9:08pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 9:08pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 9:08pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 9:08pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 9:08pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 9:08pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 9:08pm
rust-docs ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 9:08pm

Copy link
Contributor

github-actions bot commented Apr 16, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

@mehulkar mehulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me locally (which is what wasn't working before)

Copy link
Contributor

github-actions bot commented Apr 16, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

Copy link

socket-security bot commented Apr 16, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/rust@1.0.6-nightly

View full report↗︎

Copy link
Contributor

✅ This change can build next-swc

@ForsakenHarmony ForsakenHarmony merged commit d1a7d66 into main Apr 17, 2024
62 of 66 checks passed
@ForsakenHarmony ForsakenHarmony deleted the hrmny/fix-turborepo-napi-build branch April 17, 2024 11:30
kdy1 added a commit to vercel/next.js that referenced this pull request Apr 22, 2024
# Turbopack

* vercel/turborepo#7992 <!-- hrmny -
build(turbo-repository): fix napi build with LLD -->
* vercel/turborepo#7765 <!-- Tobias Koppers - Drop
excessive cells after task reexecution -->
* vercel/turborepo#7955 <!-- Donny/강동윤 - chore:
Update `styled-jsx` -->
* vercel/turborepo#7987 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.90.33` -->

### What?

Update swc crates to
swc-project/swc@0f07acb

### Why?

To keep in sync.

### How?

Closes PACK-2968
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
* vercel/turborepo#7992 <!-- hrmny -
build(turbo-repository): fix napi build with LLD -->
* vercel/turborepo#7765 <!-- Tobias Koppers - Drop
excessive cells after task reexecution -->
* vercel/turborepo#7955 <!-- Donny/강동윤 - chore:
Update `styled-jsx` -->
* vercel/turborepo#7987 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.90.33` -->

Update swc crates to
swc-project/swc@0f07acb

To keep in sync.

Closes PACK-2968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants