fix(turbopack-node) postcss.config.js path resolution on Windows #7995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the wrong name, it just silently hangs on the compilation step :/
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
kwonoj
approved these changes
Apr 17, 2024
|
There's a CI failure on Windows: However, other pull requests appear to be failing with this same error, so I don't think this is related to my PR. I'm going to go ahead and merge. |
sokra
reviewed
Apr 17, 2024
|
|
||
| const mod = await __turbopack_external_import__(configPath); | ||
| const configPath = `${{process.cwd()}}/${{{config_path}}}`; |
There was a problem hiding this comment.
This would better use path.join since the / is technically not the correct path separator on windows.
There was a problem hiding this comment.
@sokra I was trying to keep the change small, and I saw in the node documentation that:
On Windows, both the forward slash (/) and backward slash () are accepted as path segment separators; however, the path methods only add backward slashes ().
If you'd like, I can submit a follow-up PR.
Edit: #8105
bgw
added a commit
that referenced
this pull request
Apr 17, 2024
Absolute paths don't work for imports on windows because `c:\` is interpreted as a URI scheme. The workaround is to use an unambiguous `file://` URI. Fixes vercel/next.js#63755 Similar to vercel/next.js#64386
bgw
added a commit
to vercel/next.js
that referenced
this pull request
Apr 17, 2024
…ution on Windows * vercel/turborepo#7995 <!-- Benjamin Woodruff - fix(turbopack-node) postcss.config.js path resolution on Windows -->
ztanner
pushed a commit
to vercel/next.js
that referenced
this pull request
Apr 17, 2024
…ution on Windows (#64677) Not 100% sure I did this process right for a hotfix, but this new tag should be exactly the same as what's currently in the 14-2-1 branch, except with this one PR: * vercel/turborepo#7995 <!-- Benjamin Woodruff - fix(turbopack-node) postcss.config.js path resolution on Windows --> --- In turbo, I ran ``` git switch --detach turbopack-240411.3 git switch -c bgw/hotfix-turbopack-14-2-1 git cherry-pick e7a5c60a3b899d0c4293589c2844016da82442f7 git push origin HEAD ``` I then ran the GitHub action for the nightly release process for that new branch: https://github.com/vercel/turbo/actions/workflows/turbopack-nightly-release.yml (it seems like this just cuts a tag, I wonder for hotfixes if we should manually cut the tag so it's named differently) In the nextpack repository: ``` pnpm next-link turbopack-240417.2 ```
bgw
added a commit
to vercel/next.js
that referenced
this pull request
Apr 17, 2024
* vercel/turborepo#7995 <!-- Benjamin Woodruff - fix(turbopack-node) postcss.config.js path resolution on Windows --> (plus unrelated turborepo + CI changes)
bgw
added a commit
to vercel/next.js
that referenced
this pull request
Apr 17, 2024
* vercel/turborepo#7995 <!-- Benjamin Woodruff - fix(turbopack-node) postcss.config.js path resolution on Windows --> (plus unrelated turborepo + CI changes) This PR should not be cherrypicked into the 14-2-1 branch. Instead #64677 should be merged into that branch, as that PR contains only the one above Windows commit.
bgw
added a commit
that referenced
this pull request
May 7, 2024
Follow-up suggested in #7995 (comment)
sokra
pushed a commit
that referenced
this pull request
May 8, 2024
### Description A followup requested by @sokra in #7995 (comment) There's no meaningful change in behavior here, as node on windows interprets both `/` and `\` as valid path separators, but this makes the intent clearer. ### Testing Instructions <details><summary>Repeated the test plan for #7995. Tested on both Windows and Linux.</summary>  </details> Closes PACK-3049
Neosoulink
pushed a commit
to Neosoulink/turbo
that referenced
this pull request
Jun 14, 2024
### Description A followup requested by @sokra in vercel#7995 (comment) There's no meaningful change in behavior here, as node on windows interprets both `/` and `\` as valid path separators, but this makes the intent clearer. ### Testing Instructions <details><summary>Repeated the test plan for vercel#7995. Tested on both Windows and Linux.</summary>  </details> Closes PACK-3049
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…cel/turborepo#7995) Absolute paths don't work for imports on windows because `c:\` is interpreted as a URI scheme. The workaround is to use an unambiguous `file://` URI. Fixes #63755 Similar to #64386
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description A followup requested by @sokra in vercel/turborepo#7995 (comment) There's no meaningful change in behavior here, as node on windows interprets both `/` and `\` as valid path separators, but this makes the intent clearer. ### Testing Instructions <details><summary>Repeated the test plan for #7995. Tested on both Windows and Linux.</summary>  </details> Closes PACK-3049
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…cel/turborepo#7995) Absolute paths don't work for imports on windows because `c:\` is interpreted as a URI scheme. The workaround is to use an unambiguous `file://` URI. Fixes #63755 Similar to #64386
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description A followup requested by @sokra in vercel/turborepo#7995 (comment) There's no meaningful change in behavior here, as node on windows interprets both `/` and `\` as valid path separators, but this makes the intent clearer. ### Testing Instructions <details><summary>Repeated the test plan for #7995. Tested on both Windows and Linux.</summary>  </details> Closes PACK-3049
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…cel/turborepo#7995) Absolute paths don't work for imports on windows because `c:\` is interpreted as a URI scheme. The workaround is to use an unambiguous `file://` URI. Fixes #63755 Similar to #64386
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description A followup requested by @sokra in vercel/turborepo#7995 (comment) There's no meaningful change in behavior here, as node on windows interprets both `/` and `\` as valid path separators, but this makes the intent clearer. ### Testing Instructions <details><summary>Repeated the test plan for #7995. Tested on both Windows and Linux.</summary>  </details> Closes PACK-3049
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…cel/turborepo#7995) Absolute paths don't work for imports on windows because `c:\` is interpreted as a URI scheme. The workaround is to use an unambiguous `file://` URI. Fixes #63755 Similar to #64386
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description A followup requested by @sokra in vercel/turborepo#7995 (comment) There's no meaningful change in behavior here, as node on windows interprets both `/` and `\` as valid path separators, but this makes the intent clearer. ### Testing Instructions <details><summary>Repeated the test plan for #7995. Tested on both Windows and Linux.</summary>  </details> Closes PACK-3049
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#7995 <!-- Benjamin Woodruff - fix(turbopack-node) postcss.config.js path resolution on Windows --> (plus unrelated turborepo + CI changes) This PR should not be cherrypicked into the 14-2-1 branch. Instead #64677 should be merged into that branch, as that PR contains only the one above Windows commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Absolute paths don't work for imports on windows because
c:\is interpreted as a URI scheme. The workaround is to use an unambiguousfile://URI.Fixes vercel/next.js#63755
Similar to vercel/next.js#64386
Testing Instructions
patch next.js's Cargo.toml to point to the updated branch
build the next-swc binary
Run `next dev` in the test repo
Closes PACK-2972