feat: require packageManager in package.json #8017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
chris-olszewski
force-pushed
the
turborepo_2
branch
3 times, most recently
from
7a23a62
to
678e414
Compare
chris-olszewski
force-pushed
the
chrisolszewski/turbo-2707-require-packagemanager
branch
from
8e3d15b
to
667d38b
Compare
chris-olszewski
deleted the
chrisolszewski/turbo-2707-require-packagemanager
branch
chris-olszewski
added a commit
that referenced
this pull request
May 10, 2024
### Description With 2.0 we will now be requiring a `packageManager` field in `package.json` as this is a best practice and it helps us behave in a deterministic manner. The actual code change is very straightforward as we remove our package manager inference code and return an error if reading package manager from `package.json` fails. Most of the PR is updating tests. ### Testing Instructions Updated unit tests
chris-olszewski
added a commit
that referenced
this pull request
May 14, 2024
### Description With 2.0 we will now be requiring a `packageManager` field in `package.json` as this is a best practice and it helps us behave in a deterministic manner. The actual code change is very straightforward as we remove our package manager inference code and return an error if reading package manager from `package.json` fails. Most of the PR is updating tests. ### Testing Instructions Updated unit tests
chris-olszewski
added a commit
that referenced
this pull request
May 20, 2024
### Description With 2.0 we will now be requiring a `packageManager` field in `package.json` as this is a best practice and it helps us behave in a deterministic manner. The actual code change is very straightforward as we remove our package manager inference code and return an error if reading package manager from `package.json` fails. Most of the PR is updating tests. ### Testing Instructions Updated unit tests
chris-olszewski
added a commit
that referenced
this pull request
May 22, 2024
### Description With 2.0 we will now be requiring a `packageManager` field in `package.json` as this is a best practice and it helps us behave in a deterministic manner. The actual code change is very straightforward as we remove our package manager inference code and return an error if reading package manager from `package.json` fails. Most of the PR is updating tests. ### Testing Instructions Updated unit tests
chris-olszewski
added a commit
that referenced
this pull request
May 28, 2024
### Description With 2.0 we will now be requiring a `packageManager` field in `package.json` as this is a best practice and it helps us behave in a deterministic manner. The actual code change is very straightforward as we remove our package manager inference code and return an error if reading package manager from `package.json` fails. Most of the PR is updating tests. ### Testing Instructions Updated unit tests
chris-olszewski
added a commit
that referenced
this pull request
May 29, 2024
### Description With 2.0 we will now be requiring a `packageManager` field in `package.json` as this is a best practice and it helps us behave in a deterministic manner. The actual code change is very straightforward as we remove our package manager inference code and return an error if reading package manager from `package.json` fails. Most of the PR is updating tests. ### Testing Instructions Updated unit tests
chris-olszewski
added a commit
that referenced
this pull request
May 31, 2024
### Description With 2.0 we will now be requiring a `packageManager` field in `package.json` as this is a best practice and it helps us behave in a deterministic manner. The actual code change is very straightforward as we remove our package manager inference code and return an error if reading package manager from `package.json` fails. Most of the PR is updating tests. ### Testing Instructions Updated unit tests
chris-olszewski
added a commit
that referenced
this pull request
Jun 4, 2024
### Description With 2.0 we will now be requiring a `packageManager` field in `package.json` as this is a best practice and it helps us behave in a deterministic manner. The actual code change is very straightforward as we remove our package manager inference code and return an error if reading package manager from `package.json` fails. Most of the PR is updating tests. ### Testing Instructions Updated unit tests
chris-olszewski
added a commit
that referenced
this pull request
Jul 12, 2024
### Description Give users the ability to opt out of the required package manager if they feel strongly. This is still highly discouraged as this prevents proper usage of daemon package watching and leaves us dependent on system configuration to infer the correct package manager. Reviewer notes: Each commit can be reviewed on it's own. The second commit just adds back code deleted in #8017 ### Testing Instructions Added unit tests where applicable for configuration. Quick manual verification of the config options: ``` [0 olszewski@chriss-mbp] /tmp/no-pm $ turbo_dev build WARNING No locally installed `turbo` found. Using version: 2.0.7-canary.0. × missing packageManager field in package.json [1 olszewski@chriss-mbp] /tmp/no-pm $ turbo_dev build --dangerously-disable-package-manager-check --output-logs=none WARNING No locally installed `turbo` found. Using version: 2.0.7-canary.0. • Packages in scope: @repo/eslint-config, @repo/typescript-config, @repo/ui, docs, web • Running build in 5 packages • Remote caching disabled Tasks: 2 successful, 2 total Cached: 2 cached, 2 total Time: 81ms >>> FULL TURBO [0 olszewski@chriss-mbp] /tmp/no-pm $ TURBO_DANGEROUSLY_DISABLE_PACKAGE_MANAGER_CHECK=true turbo_dev build --output-logs=none WARNING No locally installed `turbo` found. Using version: 2.0.7-canary.0. • Packages in scope: @repo/eslint-config, @repo/typescript-config, @repo/ui, docs, web • Running build in 5 packages • Remote caching disabled Tasks: 2 successful, 2 total Cached: 2 cached, 2 total Time: 210ms >>> FULL TURBO [0 olszewski@chriss-mbp] /tmp/no-pm $ vim turbo.json [0 olszewski@chriss-mbp] /tmp/no-pm $ tail -3 turbo.json }, "dangerouslyDisablePackageManagerCheck": true } [0 olszewski@chriss-mbp] /tmp/no-pm $ turbo_dev build --output-logs=none WARNING No locally installed `turbo` found. Using version: 2.0.7-canary.0. • Packages in scope: @repo/eslint-config, @repo/typescript-config, @repo/ui, docs, web • Running build in 5 packages • Remote caching disabled Tasks: 2 successful, 2 total Cached: 2 cached, 2 total Time: 53ms >>> FULL TURBO ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With 2.0 we will now be requiring a
packageManagerfield inpackage.jsonas this is a best practice and it helps us behave in a deterministic manner.The actual code change is very straightforward as we remove our package manager inference code and return an error if reading package manager from
package.jsonfails.Most of the PR is updating tests.
Testing Instructions
Updated unit tests