Move fs cache location. #8126
Merged
Move fs cache location. #8126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
turbo-orchestrator
bot
added
area: ci
area: docs
|
✅ This change can build |
chris-olszewski
force-pushed
the
turborepo_2
branch
from
345dbab
to
d11acea
Compare
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
turbo-orchestrator
bot
removed
area: docs
turbo-orchestrator
bot
removed
pkg: turbo-eslint
🟢 CI successful 🟢Thanks |
|
Never the saw the CI that happy 😄 |
mehulkar
approved these changes
May 13, 2024
chris-olszewski
force-pushed
the
turborepo_2
branch
from
d11acea
to
f8bea45
Compare
chris-olszewski
approved these changes
May 14, 2024
|
@chris-olszewski If I knew all it took was changing a hardcoded string, I would have done it a long time ago. If this makes me official, then #8157 makes me King Crab. |
chris-olszewski
added a commit
that referenced
this pull request
May 20, 2024
### Description Moves the file system cache to `.turbo` as discussed in #842. ### Testing Instructions Find your favorite Turborepo of choice and run a `turbo` command twice. You should miss cache on the first run and hit cache on the second. CLOSES TURBO-3130 --------- Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
chris-olszewski
added a commit
that referenced
this pull request
May 22, 2024
### Description Moves the file system cache to `.turbo` as discussed in #842. ### Testing Instructions Find your favorite Turborepo of choice and run a `turbo` command twice. You should miss cache on the first run and hit cache on the second. CLOSES TURBO-3130 --------- Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
chris-olszewski
added a commit
that referenced
this pull request
May 28, 2024
### Description Moves the file system cache to `.turbo` as discussed in #842. ### Testing Instructions Find your favorite Turborepo of choice and run a `turbo` command twice. You should miss cache on the first run and hit cache on the second. CLOSES TURBO-3130 --------- Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
chris-olszewski
added a commit
that referenced
this pull request
May 29, 2024
### Description Moves the file system cache to `.turbo` as discussed in #842. ### Testing Instructions Find your favorite Turborepo of choice and run a `turbo` command twice. You should miss cache on the first run and hit cache on the second. CLOSES TURBO-3130 --------- Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
chris-olszewski
added a commit
that referenced
this pull request
May 31, 2024
### Description Moves the file system cache to `.turbo` as discussed in #842. ### Testing Instructions Find your favorite Turborepo of choice and run a `turbo` command twice. You should miss cache on the first run and hit cache on the second. CLOSES TURBO-3130 --------- Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
chris-olszewski
added a commit
that referenced
this pull request
Jun 4, 2024
### Description Moves the file system cache to `.turbo` as discussed in #842. ### Testing Instructions Find your favorite Turborepo of choice and run a `turbo` command twice. You should miss cache on the first run and hit cache on the second. CLOSES TURBO-3130 --------- Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
|
@anthonyshew What are the implications of this PR in regards to https://github.com/vercel/turbo/blob/c2fb13e3101ae2a6331453a3e925d832e52ced91/docs/pages/repo/docs/ci/github-actions.mdx?plain=1#L240 Is supplying --cache-dir=.turbo still necessary with v2 if I want github actions cache to work? I'm having a hard time understanding if this PR means "the dir is now .turbo inside <workspace_package_dir>/.turbo, so we set --cache-dir in the github actions docs beacuse we want all of the packages' cache to be in one centralized dir"? |
anthonyshew
pushed a commit
that referenced
this pull request
Jun 12, 2024
### Description As I see it, since the default cache location is now `<root-dir>/turbo/.cache` due to #8126, there's no longer a point in specifying the --cache-dir=.turbo as it is redundant no? ### Testing Instructions Run a GitHub actions with https://turbo.build/repo/docs/guides/ci-vendors/github-actions#caching-with-github-actionscache and see if it caches properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the file system cache to
.turboas discussed in #842.Testing Instructions
Find your favorite Turborepo of choice and run a
turbocommand twice. You should miss cache on the first run and hit cache on the second.CLOSES TURBO-3130