feat: add doublestar to exact dir paths #8180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
turbo-orchestrator
bot
added
created-by: turborepo
pkg: create-turbo
🟢 Turbopack Benchmark CI successful 🟢Thanks |
chris-olszewski
force-pushed
the
chrisolszewski/turbo-3132-add-wildcard-globs-to-exact-dir-paths
branch
from
2509799
to
fdc0026
Compare
turbo-orchestrator
bot
removed
pkg: create-turbo
chris-olszewski
changed the title
🟢 CI successful 🟢Thanks |
chris-olszewski
requested review from
mehulkar,
codybrouwers,
NicholasLYang and
anthonyshew
and removed request for
codybrouwers
chris-olszewski
deleted the
chrisolszewski/turbo-3132-add-wildcard-globs-to-exact-dir-paths
branch
tknickman
pushed a commit
that referenced
this pull request
May 21, 2024
chris-olszewski
added a commit
that referenced
this pull request
May 22, 2024
### Description If a user provides a glob that points to a directory e.g. `dist` or `dist/` then we will add a trailing double star so that the directory contents get captured instead of just the directory entry itself. ### Testing Instructions Added unit tests for adding doublestar Added integration test for verifying that `src/` and `dist` for task inputs/outputs get treated as `src/**` and `dist/**` respectively.
chris-olszewski
added a commit
that referenced
this pull request
May 22, 2024
chris-olszewski
added a commit
that referenced
this pull request
May 28, 2024
### Description If a user provides a glob that points to a directory e.g. `dist` or `dist/` then we will add a trailing double star so that the directory contents get captured instead of just the directory entry itself. ### Testing Instructions Added unit tests for adding doublestar Added integration test for verifying that `src/` and `dist` for task inputs/outputs get treated as `src/**` and `dist/**` respectively.
chris-olszewski
added a commit
that referenced
this pull request
May 28, 2024
chris-olszewski
added a commit
that referenced
this pull request
May 29, 2024
### Description If a user provides a glob that points to a directory e.g. `dist` or `dist/` then we will add a trailing double star so that the directory contents get captured instead of just the directory entry itself. ### Testing Instructions Added unit tests for adding doublestar Added integration test for verifying that `src/` and `dist` for task inputs/outputs get treated as `src/**` and `dist/**` respectively.
chris-olszewski
added a commit
that referenced
this pull request
May 29, 2024
chris-olszewski
added a commit
that referenced
this pull request
May 31, 2024
### Description If a user provides a glob that points to a directory e.g. `dist` or `dist/` then we will add a trailing double star so that the directory contents get captured instead of just the directory entry itself. ### Testing Instructions Added unit tests for adding doublestar Added integration test for verifying that `src/` and `dist` for task inputs/outputs get treated as `src/**` and `dist/**` respectively.
chris-olszewski
added a commit
that referenced
this pull request
May 31, 2024
chris-olszewski
added a commit
that referenced
this pull request
Jun 4, 2024
### Description If a user provides a glob that points to a directory e.g. `dist` or `dist/` then we will add a trailing double star so that the directory contents get captured instead of just the directory entry itself. ### Testing Instructions Added unit tests for adding doublestar Added integration test for verifying that `src/` and `dist` for task inputs/outputs get treated as `src/**` and `dist/**` respectively.
chris-olszewski
added a commit
that referenced
this pull request
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a user provides a glob that points to a directory e.g.
distordist/then we will add a trailing double star so that the directory contents get captured instead of just the directory entry itself.Testing Instructions
Added unit tests for adding doublestar
Added integration test for verifying that
src/anddistfor task inputs/outputs get treated assrc/**anddist/**respectively.