Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove globalDotEnv and dotEnv fields #8181

Merged
merged 4 commits into from
May 21, 2024

Conversation

chris-olszewski
Copy link
Member

Description

This PR removes globalDotEnv/dotEnv in favor of globalDependencies and inputs which is now fairly ergonomic to use with the addition of $TURBO_DEFAULTS$.

This PR does not update the corresponding JS types.

Testing Instructions

Updated existing integration tests

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 21, 2024 4:24pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 4:24pm
rust-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 21, 2024 4:24pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 4:24pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 4:24pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 4:24pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 4:24pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 4:24pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 4:24pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 4:24pm

Copy link
Contributor

github-actions bot commented May 20, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@chris-olszewski chris-olszewski marked this pull request as ready for review May 20, 2024 23:56
Copy link
Contributor

github-actions bot commented May 21, 2024

🟢 CI successful 🟢

Thanks

@chris-olszewski chris-olszewski enabled auto-merge (squash) May 21, 2024 16:40
@chris-olszewski chris-olszewski merged commit 1cc5b97 into turborepo_2 May 21, 2024
55 checks passed
@chris-olszewski chris-olszewski deleted the chrisolszewski/turbo-3124-remove-dotenv branch May 21, 2024 17:33
chris-olszewski added a commit that referenced this pull request May 22, 2024
### Description

This PR removes `globalDotEnv`/`dotEnv` in favor of `globalDependencies`
and `inputs` which is now fairly ergonomic to use with the addition of
`$TURBO_DEFAULTS$`.

This PR does *not* update the corresponding JS types.

### Testing Instructions

Updated existing integration tests
chris-olszewski added a commit that referenced this pull request May 28, 2024
### Description

This PR removes `globalDotEnv`/`dotEnv` in favor of `globalDependencies`
and `inputs` which is now fairly ergonomic to use with the addition of
`$TURBO_DEFAULTS$`.

This PR does *not* update the corresponding JS types.

### Testing Instructions

Updated existing integration tests
chris-olszewski added a commit that referenced this pull request May 29, 2024
This PR removes `globalDotEnv`/`dotEnv` in favor of `globalDependencies`
and `inputs` which is now fairly ergonomic to use with the addition of
`$TURBO_DEFAULTS$`.

This PR does *not* update the corresponding JS types.

Updated existing integration tests
chris-olszewski added a commit that referenced this pull request May 31, 2024
This PR removes `globalDotEnv`/`dotEnv` in favor of `globalDependencies`
and `inputs` which is now fairly ergonomic to use with the addition of
`$TURBO_DEFAULTS$`.

This PR does *not* update the corresponding JS types.

Updated existing integration tests
chris-olszewski added a commit that referenced this pull request Jun 4, 2024
This PR removes `globalDotEnv`/`dotEnv` in favor of `globalDependencies`
and `inputs` which is now fairly ergonomic to use with the addition of
`$TURBO_DEFAULTS$`.

This PR does *not* update the corresponding JS types.

Updated existing integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants