feat: all dependencies of root package contribute to global hash #8202
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
| "dependencies": { | ||
| "util": "*" | ||
| } | ||
| } |
There was a problem hiding this comment.
I can't remember if our integration test fixtures generally use packageManager or not, but that might be useful since I know * has some weird behavior in different npm versions, especially with workspaces.
There was a problem hiding this comment.
I can't remember if our integration test fixtures generally use packageManager or not, but that might be useful since I know * has some weird behavior in different npm versions, especially with workspaces
Good callout. With package manager requirements we now force usage of corepack for all test fixture defaulting to npm if one isn't specified in the fixture. Will open a ticket to make this explicit
| @@ -17,7 +17,7 @@ Check | |||
| Tasks to Run | |||
| build | |||
| Task = build\s* (re) | |||
| Hash = 4047a6e65d7dafef | |||
| Hash = 81a933c332d3f388 | |||
There was a problem hiding this comment.
are all the hashes changing because we're including some kind of "none" value even when there are no root internal deps?
There was a problem hiding this comment.
Yes, since we're changing the Capnproto structure definition the hashing of it is shifting even when there aren't any internal deps.
chris-olszewski
deleted the
chrisolszewski/turbo-2709-root-package-internal-dependencies-treated-same-as-external
branch
### Description With this PR we will now factor in all root dependency changes. Not just external packages. Internal packages are handled by hashing all of the files contained in the package directory that aren't gitignore'd. This does have performance implications as we can end up globwalking these directories multiple times and hashing the files multiple times if they end up as task inputs. This will be addressed in a future PR. ### Testing Instructions Added integration test that displays new behavior
### Description With this PR we will now factor in all root dependency changes. Not just external packages. Internal packages are handled by hashing all of the files contained in the package directory that aren't gitignore'd. This does have performance implications as we can end up globwalking these directories multiple times and hashing the files multiple times if they end up as task inputs. This will be addressed in a future PR. ### Testing Instructions Added integration test that displays new behavior
### Description With this PR we will now factor in all root dependency changes. Not just external packages. Internal packages are handled by hashing all of the files contained in the package directory that aren't gitignore'd. This does have performance implications as we can end up globwalking these directories multiple times and hashing the files multiple times if they end up as task inputs. This will be addressed in a future PR. ### Testing Instructions Added integration test that displays new behavior
### Description With this PR we will now factor in all root dependency changes. Not just external packages. Internal packages are handled by hashing all of the files contained in the package directory that aren't gitignore'd. This does have performance implications as we can end up globwalking these directories multiple times and hashing the files multiple times if they end up as task inputs. This will be addressed in a future PR. ### Testing Instructions Added integration test that displays new behavior
|
Hi all, can someone help me understand this change better? I came here from https://turbo.build/repo/docs/crafting-your-repository/upgrading#update-turbo-run-commands I tested the following things:
Each time, I ran |
|
@dipunm I would open a discussion referencing this. Comments on merged/closed PRs are probably not going to get a response |
Description
With this PR we will now factor in all root dependency changes. Not just external packages.
Internal packages are handled by hashing all of the files contained in the package directory that aren't gitignore'd.
This does have performance implications as we can end up globwalking these directories multiple times and hashing the files multiple times if they end up as task inputs. This will be addressed in a future PR.
Testing Instructions
Added integration test that displays new behavior