Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused package manager argument parameter #8224

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
c73790e
chore: remove legacy filter flags (#7970)
chris-olszewski Apr 16, 2024
38c66f0
fix(cli): fix bad merge conflict resolution (#8035)
chris-olszewski Apr 24, 2024
2eb6e93
chore(turbo)!: remove check for legacy turbo config in package.json (…
mehulkar Apr 25, 2024
04dc416
chore(turbo)! hard error on env vars in task and global dependencies …
mehulkar Apr 25, 2024
6ecc1c3
feat: require packageManager in package.json (#8017)
chris-olszewski May 9, 2024
8215a70
feat(filter): no longer infer scope in filters (#8137)
chris-olszewski May 15, 2024
6373a42
chore!(create-turbo): remove old pm arg (#8150)
tknickman May 15, 2024
79026a2
feat: error on empty package name (#8152)
chris-olszewski May 16, 2024
5072baf
feat(filter): error on invalid filters (#8142)
chris-olszewski May 16, 2024
2949f49
Move fs cache location. (#8126)
anthonyshew May 17, 2024
c88de5d
refactor(turborepo): Rename `outputMode` to `outputLogs` in `turbo.js…
NicholasLYang May 17, 2024
6a59b6f
feat: --only now applies to package dependencies (#8163)
chris-olszewski May 17, 2024
584b25e
Rename `pipeline` to `tasks`. (#8157)
anthonyshew May 21, 2024
22abfc4
feat: add doublestar to exact dir paths (#8180)
chris-olszewski May 21, 2024
97ee648
chore: unbreak turborepo_2 (#8183)
chris-olszewski May 21, 2024
ac9f709
chore: remove `globalDotEnv` and `dotEnv` fields (#8181)
chris-olszewski May 21, 2024
812c49d
chore: make env mode strict by default (#8182)
chris-olszewski May 22, 2024
28643f5
feat: allow for negative globs in globalDeps (#8190)
chris-olszewski May 22, 2024
e46104a
chore: change turborepo licenses to MIT (#8197)
chris-olszewski May 23, 2024
81287bd
feat(codemod): add missing package names (#8186)
tknickman May 23, 2024
1988180
chore: remove --ignore flag (#8201)
chris-olszewski May 23, 2024
0985a26
feat: all dependencies of root package contribute to global hash (#8202)
chris-olszewski May 23, 2024
7cc6f21
release(turborepo): 2.0.0-canary.0 (#8206)
github-actions[bot] May 23, 2024
9b5f8a9
fix: remove unused package manager argument parameter
chris-olszewski May 28, 2024
05199fb
Merge branch 'turborepo_2' into chrisolszewski/turbo-3275-create-turb…
chris-olszewski May 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 13 additions & 19 deletions packages/create-turbo/__tests__/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,12 @@ describe("create-turbo", () => {
return "success";
});

await create(
root as CreateCommandArgument,
packageManager as CreateCommandArgument,
{
skipInstall: true,
example: "default",
telemetry,
}
);
await create(root as CreateCommandArgument, {
packageManager,
skipInstall: true,
example: "default",
telemetry,
});

const expected = `${chalk.bold(
logger.turboGradient(">>> Success!")
Expand Down Expand Up @@ -161,7 +158,7 @@ describe("create-turbo", () => {
return "success";
});

await create(root as CreateCommandArgument, undefined, {
await create(root as CreateCommandArgument, {
packageManager,
skipInstall: true,
example: "default",
Expand Down Expand Up @@ -221,15 +218,12 @@ describe("create-turbo", () => {
return "success";
});

await create(
root as CreateCommandArgument,
packageManager as CreateCommandArgument,
{
skipInstall: true,
example: "default",
telemetry,
}
);
await create(root as CreateCommandArgument, {
packageManager,
skipInstall: true,
example: "default",
telemetry,
});

expect(mockConsole.error).toHaveBeenCalledTimes(2);
expect(mockConsole.error).toHaveBeenNthCalledWith(
Expand Down
11 changes: 1 addition & 10 deletions packages/create-turbo/src/commands/create/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,27 +69,18 @@ const SCRIPTS_TO_DISPLAY: Record<string, string> = {

export async function create(
directory: CreateCommandArgument,
packageManagerCmd: CreateCommandArgument,
opts: CreateCommandOptions
) {
// track CLI command start
opts.telemetry?.trackCommandStatus({ command: "create", status: "start" });
opts.telemetry?.trackArgumentPackageManager(packageManagerCmd);
opts.telemetry?.trackArgumentDirectory(Boolean(directory));
trackOptions(opts);

const {
packageManager: packageManagerOpt,
skipInstall,
skipTransforms,
} = opts;
const { packageManager, skipInstall, skipTransforms } = opts;
logger.log(chalk.bold(turboGradient(`\n>>> TURBOREPO\n`)));
info(`Welcome to Turborepo! Let's get you set up with a new codebase.`);
logger.log();

// if both the package manager option and command are provided, the option takes precedence
const packageManager = packageManagerOpt ?? packageManagerCmd;

const [online, availablePackageManagers] = await Promise.all([
isOnline(),
getAvailablePackageManagers(),
Expand Down
Loading