Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(turborepo): Improve pipeline error message #8231

Merged
merged 2 commits into from
May 28, 2024

Conversation

NicholasLYang
Copy link
Contributor

Description

Made a nicer error message for having a pipeline key instead of tasks.

Testing Instructions

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 7:54pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 7:54pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 7:54pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 7:54pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 7:54pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 7:54pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 7:54pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 7:54pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 7:54pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 7:54pm

Copy link
Contributor

github-actions bot commented May 28, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented May 28, 2024

🟢 CI successful 🟢

Thanks

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicked the message but 🚢

crates/turborepo-lib/src/config.rs Outdated Show resolved Hide resolved
Co-authored-by: Anthony Shew <anthony.shew@vercel.com>
@NicholasLYang NicholasLYang enabled auto-merge (squash) May 28, 2024 19:52
@NicholasLYang NicholasLYang merged commit ac50e35 into turborepo_2 May 28, 2024
42 checks passed
@NicholasLYang NicholasLYang deleted the chore/pipeline-error-message branch May 28, 2024 19:53
chris-olszewski pushed a commit that referenced this pull request May 29, 2024
### Description

Made a nicer error message for having a `pipeline` key instead of
`tasks`.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->

---------

Co-authored-by: Anthony Shew <anthony.shew@vercel.com>
chris-olszewski pushed a commit that referenced this pull request May 31, 2024
### Description

Made a nicer error message for having a `pipeline` key instead of
`tasks`.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->

---------

Co-authored-by: Anthony Shew <anthony.shew@vercel.com>
chris-olszewski pushed a commit that referenced this pull request Jun 4, 2024
### Description

Made a nicer error message for having a `pipeline` key instead of
`tasks`.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->

---------

Co-authored-by: Anthony Shew <anthony.shew@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants