impl Ord for Diagnostics and Issue so they are sorted correctly #8805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
wbinnssmith
approved these changes
Jul 22, 2024
This was referenced Jul 23, 2024
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Jul 23, 2024
In larger apps, when compilation can take time and endpoints are often build concurrently, `endpoint_server_changed_subscribe`’s subscription to turbotasks can result in unnecessary calls of the JS callback even when turbotasks input has not changed. This wraps subscribing to issues and diagnostics in `endpoint_server_changed_subscribe` within a turbotasks function that ensures that inputs are properly consistent (e.g. diagnostics have been sorted and are value-equal) so this callback is not called unnecessary. Test Plan: Navigate within a large app and verify `serverComponentChanges` messages are not sent through the web socket connection and the browser does not perform unnecessary fetch requests to rsc endpoints. ### Turbopack Changes * vercel/turborepo#8777 <!-- Tobias Koppers - merge InProgressDirty into InProgress --> * vercel/turborepo#8785 <!-- Tobias Koppers - fix watcher bug with file creation --> * vercel/turborepo#8793 <!-- Tobias Koppers - get rid of notify-debouncer in favor of our own debouncing --> * vercel/turborepo#8805 <!-- Tobias Koppers - impl Ord for Diagnostics and Issue so they are sorted correctly --> --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…el/turborepo#8805) ### Description impl Ord for Diagnostics and Issue so they are sorted correctly Collectibles are unordered by default and need to be ordered correctly to avoid over invalidation ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…el/turborepo#8805) ### Description impl Ord for Diagnostics and Issue so they are sorted correctly Collectibles are unordered by default and need to be ordered correctly to avoid over invalidation ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…el/turborepo#8805) ### Description impl Ord for Diagnostics and Issue so they are sorted correctly Collectibles are unordered by default and need to be ordered correctly to avoid over invalidation ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…el/turborepo#8805) ### Description impl Ord for Diagnostics and Issue so they are sorted correctly Collectibles are unordered by default and need to be ordered correctly to avoid over invalidation ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 14, 2024
In larger apps, when compilation can take time and endpoints are often build concurrently, `endpoint_server_changed_subscribe`’s subscription to turbotasks can result in unnecessary calls of the JS callback even when turbotasks input has not changed. This wraps subscribing to issues and diagnostics in `endpoint_server_changed_subscribe` within a turbotasks function that ensures that inputs are properly consistent (e.g. diagnostics have been sorted and are value-equal) so this callback is not called unnecessary. Test Plan: Navigate within a large app and verify `serverComponentChanges` messages are not sent through the web socket connection and the browser does not perform unnecessary fetch requests to rsc endpoints. ### Turbopack Changes * vercel/turborepo#8777 <!-- Tobias Koppers - merge InProgressDirty into InProgress --> * vercel/turborepo#8785 <!-- Tobias Koppers - fix watcher bug with file creation --> * vercel/turborepo#8793 <!-- Tobias Koppers - get rid of notify-debouncer in favor of our own debouncing --> * vercel/turborepo#8805 <!-- Tobias Koppers - impl Ord for Diagnostics and Issue so they are sorted correctly --> --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 15, 2024
In larger apps, when compilation can take time and endpoints are often build concurrently, `endpoint_server_changed_subscribe`’s subscription to turbotasks can result in unnecessary calls of the JS callback even when turbotasks input has not changed. This wraps subscribing to issues and diagnostics in `endpoint_server_changed_subscribe` within a turbotasks function that ensures that inputs are properly consistent (e.g. diagnostics have been sorted and are value-equal) so this callback is not called unnecessary. Test Plan: Navigate within a large app and verify `serverComponentChanges` messages are not sent through the web socket connection and the browser does not perform unnecessary fetch requests to rsc endpoints. ### Turbopack Changes * vercel/turborepo#8777 <!-- Tobias Koppers - merge InProgressDirty into InProgress --> * vercel/turborepo#8785 <!-- Tobias Koppers - fix watcher bug with file creation --> * vercel/turborepo#8793 <!-- Tobias Koppers - get rid of notify-debouncer in favor of our own debouncing --> * vercel/turborepo#8805 <!-- Tobias Koppers - impl Ord for Diagnostics and Issue so they are sorted correctly --> --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
In larger apps, when compilation can take time and endpoints are often build concurrently, `endpoint_server_changed_subscribe`’s subscription to turbotasks can result in unnecessary calls of the JS callback even when turbotasks input has not changed. This wraps subscribing to issues and diagnostics in `endpoint_server_changed_subscribe` within a turbotasks function that ensures that inputs are properly consistent (e.g. diagnostics have been sorted and are value-equal) so this callback is not called unnecessary. Test Plan: Navigate within a large app and verify `serverComponentChanges` messages are not sent through the web socket connection and the browser does not perform unnecessary fetch requests to rsc endpoints. ### Turbopack Changes * vercel/turborepo#8777 <!-- Tobias Koppers - merge InProgressDirty into InProgress --> * vercel/turborepo#8785 <!-- Tobias Koppers - fix watcher bug with file creation --> * vercel/turborepo#8793 <!-- Tobias Koppers - get rid of notify-debouncer in favor of our own debouncing --> * vercel/turborepo#8805 <!-- Tobias Koppers - impl Ord for Diagnostics and Issue so they are sorted correctly --> --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
impl Ord for Diagnostics and Issue so they are sorted correctly
Collectibles are unordered by default and need to be ordered correctly to avoid over invalidation
Testing Instructions