Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(telemetry): remove unused codepath field #8855

Merged
merged 1 commit into from
Jul 26, 2024
Merged

chore(telemetry): remove unused codepath field #8855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion crates/turborepo-lib/src/cli/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
use turborepo_repository::inference::{RepoMode, RepoState};
use turborepo_telemetry::{
events::{
command::{CodePath, CommandEventBuilder},

Check warning on line 18 in crates/turborepo-lib/src/cli/mod.rs

View workflow job for this annotation

GitHub Actions / Build Turborepo (ubuntu, self-hosted, linux, x64, metal) 

unused import: `CodePath`

Check warning on line 18 in crates/turborepo-lib/src/cli/mod.rs

View workflow job for this annotation

GitHub Actions / Turborepo rust check 

unused import: `CodePath`

Check warning on line 18 in crates/turborepo-lib/src/cli/mod.rs

View workflow job for this annotation

GitHub Actions / Build Turborepo (macos, macos-12) 

unused import: `CodePath`

Check warning on line 18 in crates/turborepo-lib/src/cli/mod.rs

View workflow job for this annotation

GitHub Actions / Build Turborepo (windows, windows-latest) 

unused import: `CodePath`

Check warning on line 18 in crates/turborepo-lib/src/cli/mod.rs

View workflow job for this annotation

GitHub Actions / Turborepo rust clippy 

unused import: `CodePath`

Check warning on line 18 in crates/turborepo-lib/src/cli/mod.rs

View workflow job for this annotation

GitHub Actions / Turborepo Rust testing on ubuntu 

unused import: `CodePath`

Check warning on line 18 in crates/turborepo-lib/src/cli/mod.rs

View workflow job for this annotation

GitHub Actions / Turborepo Rust testing on macos 

unused import: `CodePath`

Check warning on line 18 in crates/turborepo-lib/src/cli/mod.rs

View workflow job for this annotation

GitHub Actions / Turborepo Rust testing on windows 

unused import: `CodePath`

Check warning on line 18 in crates/turborepo-lib/src/cli/mod.rs

View workflow job for this annotation

GitHub Actions / Turborepo Integration (ubuntu-latest) 

unused import: `CodePath`

Check warning on line 18 in crates/turborepo-lib/src/cli/mod.rs

View workflow job for this annotation

GitHub Actions / Turborepo Integration (macos-12) 

unused import: `CodePath`

Check warning on line 18 in crates/turborepo-lib/src/cli/mod.rs

View workflow job for this annotation

GitHub Actions / Turborepo Integration (windows-latest) 

unused import: `CodePath`
generic::GenericEventBuilder,
EventBuilder, EventType,
},
Expand Down Expand Up @@ -1257,7 +1257,6 @@
}

run_args.track(&event);
event.track_run_code_path(CodePath::Rust);
let exit_code = run::run(base, event).await.inspect(|code| {
if *code != 0 {
error!("run failed: command exited ({code})");
Expand Down
13 changes: 0 additions & 13 deletions crates/turborepo-telemetry/src/events/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,19 +126,6 @@ impl CommandEventBuilder {
self
}

// run
pub fn track_run_code_path(&self, path: CodePath) -> &Self {
self.track(Event {
key: "binary".to_string(),
value: match path {
CodePath::Go => "go".to_string(),
CodePath::Rust => "rust".to_string(),
},
is_sensitive: EventType::NonSensitive,
});
self
}

// login
pub fn track_login_method(&self, method: LoginMethod) -> &Self {
self.track(Event {
Expand Down
Loading