fix: Fix tree shaking even more #8864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3304ada5149e3b0ebb9f51bfaa52d7a45b1fb0db.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
kdy1
commented
Jul 30, 2024
kdy1
commented
Jul 30, 2024
| @@ -175,7 +175,7 @@ impl Module for EcmascriptModulePartAsset { | |||
| impl Asset for EcmascriptModulePartAsset { | |||
| #[turbo_tasks::function] | |||
| fn content(&self) -> Vc<AssetContent> { | |||
| todo!() | |||
| self.full_module.content() | |||
There was a problem hiding this comment.
The value is still not used.
sokra
approved these changes
Jul 30, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 30, 2024
### Description Fix server action and rename the injected variable. The previous code fails if the name of the top-level variable is `v`. This was not a problem for almost all modules, but some packages like [`@firebase/webchannel-wrapper`](https://unpkg.com/@firebase/webchannel-wrapper@0.2.41/dist/index.esm.js) is published after mangling, so it can be a problem ### Testing Instructions See #66689
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description Fix server action and rename the injected variable. The previous code fails if the name of the top-level variable is `v`. This was not a problem for almost all modules, but some packages like [`@firebase/webchannel-wrapper`](https://unpkg.com/@firebase/webchannel-wrapper@0.2.41/dist/index.esm.js) is published after mangling, so it can be a problem ### Testing Instructions See #66689
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix server action and rename the injected variable.
The previous code fails if the name of the top-level variable is
v. This was not a problem for almost all modules, but some packages like@firebase/webchannel-wrapperis published after mangling, so it can be a problemTesting Instructions
See vercel/next.js#66689