feat(turborepo): web ui #8895
feat(turborepo): web ui #8895
Conversation
turbo-orchestrator
bot
added
area: examples
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Skipped Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
NicholasLYang
force-pushed
the
nicholasyang/web-ui
branch
from
c857ccc
to
1abcc6b
Compare
NicholasLYang
force-pushed
the
nicholasyang/web-ui
branch
from
1abcc6b
to
23fd9b2
Compare
turbo-orchestrator
bot
removed
the
area: examples
NicholasLYang
force-pushed
the
nicholasyang/web-ui
branch
from
6592b5f
to
96183a6
Compare
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
NicholasLYang
force-pushed
the
nicholasyang/web-ui
branch
from
96183a6
to
76fed76
Compare
NicholasLYang
force-pushed
the
nicholasyang/web-ui
branch
from
2221f05
to
21dc102
Compare
| pub async fn start_server( | ||
| rx: tokio::sync::mpsc::UnboundedReceiver<WebUIEvent>, | ||
| ) -> Result<(), crate::Error> { | ||
| let state = Arc::new(Mutex::new(RefCell::new(WebUIState::default()))); |
There was a problem hiding this comment.
I'm not sure if I understand the use of RefCell inside of the Mutex. Doesn't the Mutex already ensure that there's only ever one access to the underlying data at a time? Why are dynamic borrows necessary inside of the restriction?
If this is necessary a quick comment explaining why would be very appreciated.
There was a problem hiding this comment.
It's so Subscriber can mutate the state even though it's behind an immutable reference. We can't have a mutable reference because Query also needs to hold a reference to it.
Description
Implements a very very alpha version of a web UI. Uses a GraphQL query to get the current run and tasks.
Testing Instructions
Would love some ideas here on tests.
To try out manually, go to #35066 in the other repo and run
turbo-studio, then execute a turbo command with theuiflag set toweb