Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add -w flag to pnpm example #9160

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

giraffesyo
Copy link
Contributor

@giraffesyo giraffesyo commented Sep 17, 2024

It's suggested to install this into the repository root. If you do this, you must use --workspace-root flag or you will get this error:

 ERR_PNPM_ADDING_TO_ROOT  Running this command will add the dependency to the workspace root, which might not be what you want - if you really meant it, make it explicit by running this command again with the -w flag (or --workspace-root). If you don't want to see this warning anymore, you may set the ignore-workspace-root-check setting to true.

It's suggested to install this into the repository root. If you do this, you must used `-w` flag or you will get this error:


>  ERR_PNPM_ADDING_TO_ROOT  Running this command will add the dependency to the workspace root, which might not be what you want - if you really meant it, make it explicit by running this command again with the -w flag (or --workspace-root). If you don't want to see this warning anymore, you may set the ignore-workspace-root-check setting to true.
@giraffesyo giraffesyo requested review from anthonyshew and a team as code owners September 17, 2024 15:05
@turbo-orchestrator turbo-orchestrator bot added area: docs Improvements or additions to documentation needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Sep 17, 2024
@giraffesyo giraffesyo changed the title docs: add -w flag to pnpm exmaple docs: add -w flag to pnpm example Sep 17, 2024
Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 9:21pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 9:21pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 9:21pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 9:21pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 9:21pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 9:21pm

Copy link

vercel bot commented Sep 17, 2024

@giraffesyo is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for this nitpick but we prefer to use the long form of flags. Could you update to --workspace-root instead of -w?

@giraffesyo
Copy link
Contributor Author

I apologize for this nitpick but we prefer to use the long form of flags. Could you update to --workspace-root instead of -w?

sounds good, just updated that.

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants