Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): add test for cyclic error #9305

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

chris-olszewski
Copy link
Member

Description

As mentioned in #9270 we currently output all strongly connected components. This PR just adds a test to display the current behavior where we show the set of nodes and not all cycles that might be contained in the SCC.

Testing Instructions

Test runs and CI is green

@chris-olszewski chris-olszewski marked this pull request as ready for review October 22, 2024 13:21
@chris-olszewski chris-olszewski requested a review from a team as a code owner October 22, 2024 13:21
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 1:21pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Oct 22, 2024 1:21pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Oct 22, 2024 1:21pm
examples-gatsby-web ⬜️ Ignored (Inspect) Oct 22, 2024 1:21pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Oct 22, 2024 1:21pm
examples-native-web ⬜️ Ignored (Inspect) Oct 22, 2024 1:21pm
examples-svelte-web ⬜️ Ignored (Inspect) Oct 22, 2024 1:21pm
examples-tailwind-web ⬜️ Ignored (Inspect) Oct 22, 2024 1:21pm
examples-vite-web ⬜️ Ignored (Inspect) Oct 22, 2024 1:21pm

@chris-olszewski chris-olszewski enabled auto-merge (squash) October 22, 2024 13:46
@chris-olszewski chris-olszewski merged commit 5e47ff6 into main Oct 22, 2024
40 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/chore_cyclic_err branch October 22, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants