Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test-utils): return promise from lifecycle #9331

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

tknickman
Copy link
Member

Description

From Jest docs (here)

beforeEach and afterEach can handle asynchronous code in the same ways that tests can handle asynchronous code - they can either take a done parameter or return a promise

Testing Instructions

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 3:03pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Oct 24, 2024 3:03pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Oct 24, 2024 3:03pm
examples-gatsby-web ⬜️ Ignored (Inspect) Oct 24, 2024 3:03pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Oct 24, 2024 3:03pm
examples-native-web ⬜️ Ignored (Inspect) Oct 24, 2024 3:03pm
examples-svelte-web ⬜️ Ignored (Inspect) Oct 24, 2024 3:03pm
examples-tailwind-web ⬜️ Ignored (Inspect) Oct 24, 2024 3:03pm
examples-vite-web ⬜️ Ignored (Inspect) Oct 24, 2024 3:03pm

@tknickman tknickman merged commit 2d5200f into main Oct 24, 2024
39 checks passed
@tknickman tknickman deleted the tomknickman/use-fixture-bug branch October 24, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants