Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mfe): avoid crashing if unsupported mfe version found #9432

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

chris-olszewski
Copy link
Member

Description

We should avoid crashing if we encounter a version of MFE config that we don't currently support.

Testing Instructions

Added unit test. Quick spot check by changing version in an example to an unsupported version:

[1 olszewski@chriss-mbp] /Users/olszewski/code/ $ turbo_dev --skip-infer micro-frontends-example-web#dev --dry=json > /dev/null
turbo 2.2.4-canary.10

 WARNING  Ignoring /Users/olszewski/code/packages/micro-frontends-example-site-config/micro-frontends.jsonc: Unsupported micro-frontends configuration version: 2. Supported versions: ["1"]

@chris-olszewski chris-olszewski marked this pull request as ready for review November 13, 2024 17:06
@chris-olszewski chris-olszewski requested a review from a team as a code owner November 13, 2024 17:06
Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 5:06pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Nov 13, 2024 5:06pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Nov 13, 2024 5:06pm
examples-gatsby-web ⬜️ Ignored (Inspect) Nov 13, 2024 5:06pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Nov 13, 2024 5:06pm
examples-native-web ⬜️ Ignored (Inspect) Nov 13, 2024 5:06pm
examples-svelte-web ⬜️ Ignored (Inspect) Nov 13, 2024 5:06pm
examples-tailwind-web ⬜️ Ignored (Inspect) Nov 13, 2024 5:06pm
examples-vite-web ⬜️ Ignored (Inspect) Nov 13, 2024 5:06pm

@chris-olszewski chris-olszewski enabled auto-merge (squash) November 13, 2024 17:11
@chris-olszewski chris-olszewski merged commit 43ab1c7 into main Nov 13, 2024
40 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/chore_gate_mfe_version branch November 13, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants