Overwrite default timeout #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
commented
May 22, 2018
| @@ -106,7 +107,7 @@ const loadPackage = (url, authInfo) => new Promise((resolve, reject) => { | |||
| reject(e); | |||
| } | |||
| }); | |||
| }).on('error', reject); | |||
| }).on('error', reject).on('timeout', reject); | |||
There was a problem hiding this comment.
Setting timeout will only add a timeout event to the event emitter.
See https://nodejs.org/api/http.html#http_http_request_options_callback at the bottom:
Note that setting the timeout option or using the setTimeout() function will not abort the request or do anything besides add a 'timeout' event.
leo
approved these changes
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As talked about with @leo, the default timeout is apparently rather long (2 minutes). This makes sure everything keeps running when npm starts timing out.