Skip to content
This repository has been archived by the owner on Jun 16, 2024. It is now read-only.

Commit

Permalink
fix: plugin type is not part of the name (#21)
Browse files Browse the repository at this point in the history
If we use the plugin type as part of the name, then we must use the pluging type in the config.yaml and looks pretty odd
  • Loading branch information
juanpicado authored Dec 26, 2019
1 parent f412a03 commit 8e69fa6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions generators/app/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export default class VerdaccioPluginGenerator extends Generator {
// To access props later use this.props.someAnswer;
// @ts-ignore
this.props = _props;
const { name, pluginType, githubUsername } = _props;
const { name, githubUsername } = _props;
// @ts-ignore
this.props.license = "MIT";
if (githubUsername) {
Expand All @@ -105,7 +105,7 @@ export default class VerdaccioPluginGenerator extends Generator {
}

// @ts-ignore
this.projectName = `verdaccio-${pluginType}-${name}`;
this.projectName = `verdaccio-${name}`;

// @ts-ignore
this.destinationPathName = resolve(this.projectName);
Expand Down
2 changes: 1 addition & 1 deletion test/generator-template.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe('template generator', function() {
const license = 'MIT';
const repository = 'verdaccio/generator-test';
const getBuildAsset = (tempRoot, pluginType, item) => {
const prefixPath = path.join(tempRoot, `/verdaccio-${pluginType}-${name}`);
const prefixPath = path.join(tempRoot, `/verdaccio-${name}`);
return `${prefixPath}/${item}`;
}

Expand Down

0 comments on commit 8e69fa6

Please sign in to comment.